Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile page UI #639

Merged
merged 18 commits into from
Jul 12, 2023
Merged

Profile page UI #639

merged 18 commits into from
Jul 12, 2023

Conversation

anamika7153
Copy link
Contributor

Closes: #601

Before Updated
image
image
image

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we please reduce/optimise media queries?
also, the back button is lagging as you can see
image

Also mobile display is like this now
image

src/pages/Profile/index.css Outdated Show resolved Hide resolved
@anamika7153
Copy link
Contributor Author

@narayan954 I'm on it.

@narayan954
Copy link
Owner

@narayan954 I'm on it.

best of luck!

@narayan954
Copy link
Owner

Also, maybe we dont need that back button here, as other options are available directly in the sidebar. You may remove that

@anamika7153
Copy link
Contributor Author

Also, maybe we dont need that back button here, as other options are available directly in the sidebar. You may remove that

Noted

@narayan954 narayan954 marked this pull request as draft July 7, 2023 15:58
@anamika7153 anamika7153 marked this pull request as ready for review July 12, 2023 18:59
@anamika7153 anamika7153 marked this pull request as draft July 12, 2023 19:01
@anamika7153 anamika7153 marked this pull request as ready for review July 12, 2023 19:17
@anamika7153
Copy link
Contributor Author

Screenshots

image image
image image

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit 0e94a88 into narayan954:master Jul 12, 2023
4 of 5 checks passed
narayan954 added a commit to Palakkgoyal/dummygram that referenced this pull request Jul 13, 2023
* profile page ui

* reset profile component

* reset profile css

* enhanced profile page ui

* profile info section responsive for mobiles

---------

Co-authored-by: Narayan soni <narayansoni854@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[FEATURE] Profile page UI Enhancement
2 participants