Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve sign up page ui #686

Merged
merged 9 commits into from
Jul 12, 2023
Merged

improve sign up page ui #686

merged 9 commits into from
Jul 12, 2023

Conversation

Walexz01
Copy link
Contributor

@Walexz01 Walexz01 commented Jul 6, 2023 •
edited
Loading

#642

improve sign up page ui

@narayansoni

Beforre
Screenshot_20230706_102322

After

Screenshot_20230706_122312

@Walexz01 Walexz01 mentioned this pull request Jul 6, 2023
Closed
@narayan954
Copy link
Owner

#642

improve sign up page ui

@narayansoni

Beforre Screenshot_20230706_102322

After

Screenshot_20230706_122312

Hi @Walexz01 can you check the signup page, it's not right at all, also the images etc are stretching way too much
image

narayan954
narayan954 requested changes Jul 6, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the ui error

@Walexz01
Copy link
Contributor Author

Walexz01 commented Jul 6, 2023

Ok sir will check it now

@Walexz01
Copy link
Contributor Author

Walexz01 commented Jul 6, 2023 •
edited
Loading

@narayan954 done sir

Screenshot_20230706_105755

@narayan954
Copy link
Owner

@narayan954 done sir

Screenshot_20230706_105755

hello @Walexz01 , do make this to fit in the viewport, there shouldn't be any need to scroll in normal viewport(without any zoom effects)

@narayan954
Copy link
Owner

you can let the signup form be scrollable but the image on the right should fit in properly like login page. That'd be better.
Take you time

@narayan954 narayan954 marked this pull request as draft July 7, 2023 17:09
@Walexz01
Copy link
Contributor Author

Walexz01 commented Jul 9, 2023 •
edited
Loading

Ok sir
Will work on it

@narayan954
Copy link
Owner

you can let the signup form be scrollable but the image on the right should fit in properly like login page. That'd be better. Take you time

let's have this as the next issue, currently we should just focus on the new UI

@Walexz01
Copy link
Contributor Author

ok sir

@Walexz01 Walexz01 marked this pull request as ready for review July 11, 2023 10:56
narayan954
narayan954 approved these changes Jul 12, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 linked an issue Jul 12, 2023 that may be closed by this pull request
Improve the sign up page #642
Closed
@narayan954 narayan954 merged commit a3723f9 into narayan954:master Jul 12, 2023
4 of 5 checks passed
@narayan954
Copy link
Owner

Thanks for your contribution!

@Walexz01
Copy link
Contributor Author

@narayan954 aalways happy to contribute sir ❤️

narayan954 added a commit to Palakkgoyal/dummygram that referenced this pull request Jul 13, 2023
@Walexz01 @narayan954
improve sign up page ui (narayan954#686)
6ae8c02 
* create sign up page

* format code

* fix the ui issues

* fis the sign up image

* format code

* removed unused imports

---------

Co-authored-by: Narayan soni <narayansoni854@gmail.com>
@Walexz01 Walexz01 deleted the sign__up__page branch July 13, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narayan954 narayan954 narayan954 approved these changes

Assignees
No one assigned
Labels
codepeak level2
Projects
Dummygram
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the sign up page
2 participants
@Walexz01 @narayan954