Fixed: Posting empty comments #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narayan954
approved these changes
Jul 12, 2023
src/components/Post/CommentBox.jsx
Outdated
| @@ -60,7 +61,7 @@ const CommentBox = ({ | |||
|
|
|||
| <IconButton | |||
| className="post__button" | |||
| disabled={!comment} | |||
| disabled={!comment || comment.trim().length < 1} | |||
There was a problem hiding this comment.
won't comment.trim().length < 1 work the same as !comment? I think we wont need that
There was a problem hiding this comment.
!comment checks if its not null, undefined. But comment.trim().length < 1 check if the comment is empty or contains only white spaces.
But you are right. In this LOC, !comment seems redundant.
narayan954
added a commit
to Palakkgoyal/dummygram
that referenced
this pull request
Jul 13, 2023
* Fixed: Posting empty comments * removed extra condition * add changes back --------- Co-authored-by: Narayan soni <narayansoni854@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #740.