Add username #752
Merged
Add username #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narayan954
reviewed
Jul 13, 2023
|
Hi @Palakkgoyal can you please resolve conflicts? If you face issues, let me know. |
Sure. |
Palakkgoyal
force-pushed
the
addUsername
branch
2 times, most recently
from
aeed2bd
to
20f9a12
Compare
|
I solved the merge issue. Can you please check. |
1 similar comment
|
I solved the merge issue. Can you please check. |
new pr? or should I reopen this?? |
|
I didn't closed this. It get closed automatically. Should I make a new one? |
nono I reopened it, so it's fine now, will review and merge in a while |
|
Ohk. Thanks a lot. |
|
Thanks a lot for fixing this! |
|
No worries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes issue no. #574
Done all the required changes such as checking whether the user exist or not. If not then, create a new user doc in users collection and if does exists then, check whether they have a username or not. If not then, give them uid as their username and if exists then, do not do anything in both sign in and sign up page.