Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile modal #758

Merged
merged 6 commits into from
Jul 13, 2023
Merged

Profile modal #758

merged 6 commits into from
Jul 13, 2023

Conversation

anamika7153
Copy link
Contributor

@anamika7153 anamika7153 commented Jul 11, 2023 •
edited
Loading

Screenshots
My profile Other's profile

narayan954
narayan954 requested changes Jul 13, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are same lines repeating? is this working?? line 270 to 365 are repeating from 385 perhaps, can you please recheck?

@anamika7153
Copy link
Contributor Author

anamika7153 commented Jul 13, 2023 •
edited
Loading

why are same lines repeating? is this working?? line 270 to 365 are repeating from 385 perhaps, can you please recheck?

before, on clicking the avatar a modal opens and shows the user image in a circle.
What i have done is, on clicking the logged in user will see his profile pic and below it the option to update photo and dor other users the avatar displays profile pic in a square taking full height and width of the modal.
It is repeating because the profile page displays the image and edit pic and modal displays it too.
Before after
image 252707752-e16d819d-5c2f-4aec-b242-99d50bf22f18
image image

@narayan954
Copy link
Owner

why are same lines repeating? is this working?? line 270 to 365 are repeating from 385 perhaps, can you please recheck?

before, on clicking the avatar a modal opens and shows the user image in a circle. What i have done is, on clicking the logged in user will see his profile pic and below it the option to update photo and dor other users the avatar displays profile pic in a square taking full height and width of the modal. It is repeating because the profile page displays the image and edit pic and modal displays it too.

Before after
image 252707752-e16d819d-5c2f-4aec-b242-99d50bf22f18
image image

ohh okay

narayan954
narayan954 approved these changes Jul 13, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit 6bfeb66 into narayan954:master Jul 13, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narayan954 narayan954 narayan954 approved these changes

Assignees
No one assigned
Labels
codepeak level1
Projects
Dummygram
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Profile avatar on click blank modal
2 participants
@anamika7153 @narayan954