Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing home buttons #793

Merged
merged 11 commits into from
Jul 14, 2023
Merged

Conversation

NandiniGera
Copy link
Contributor

ABOUT PAGE
image

CONTRIBUTOR PAGE
image

HELP PAGE
image

GUIDELINES/POLICY PAGE
image

All buttons route back to the home page.

@NandiniGera
Copy link
Contributor Author

Completes issue #763

@narayan954
Copy link
Owner

narayan954 commented Jul 13, 2023

ABOUT PAGE

CONTRIBUTOR PAGE

HELP PAGE

GUIDELINES/POLICY PAGE

All buttons route back to the home page.

Hi @NandiniGera content of pages other than about page is deviating from center .
Also it's not at all responsive to any screen as you can seen in the screenshot below. Button is lost at most screens.
image

let the content be centred as it is. Some of the approaches are:
1 instead of back to home button add this same functionality as a cross/cancel button in the top right corner of the glassy division.
2 add the back button on navbar (not recommended)
3 use the current button but position it such that content remains at center completely as it is and button is visible as well.

@NandiniGera
Copy link
Contributor Author

ABOUT PAGE
CONTRIBUTOR PAGE
HELP PAGE
GUIDELINES/POLICY PAGE
All buttons route back to the home page.

Hi @NandiniGera content of pages other than about page is deviating from center . Also it's not at all responsive to any screen as you can seen in the screenshot below. Button is lost at most screens. image

let the content be centred as it is. Some of the approaches are: 1 instead of back to home button add this same functionality as a cross/cancel button in the top right corner of the glassy division. 2 add the back button on navbar (not recommended) 3 use the current button but position it such that content remains at center completely as it is and button is visible as well.

Hi, Actually without deviating from the glass division, I was not able to add the button on the Contributors and Guidelines Page:/
Thank you for the approaches, I'll try to fix it asap :)

@narayan954
Copy link
Owner

ABOUT PAGE
CONTRIBUTOR PAGE
HELP PAGE
GUIDELINES/POLICY PAGE
All buttons route back to the home page.

Hi @NandiniGera content of pages other than about page is deviating from center . Also it's not at all responsive to any screen as you can seen in the screenshot below. Button is lost at most screens. image
let the content be centred as it is. Some of the approaches are: 1 instead of back to home button add this same functionality as a cross/cancel button in the top right corner of the glassy division. 2 add the back button on navbar (not recommended) 3 use the current button but position it such that content remains at center completely as it is and button is visible as well.

Hi, Actually without deviating from the glass division, I was not able to add the button on the Contributors and Guidelines Page:/ Thank you for the approaches, I'll try to fix it asap :)

ohh alright

@NandiniGera
Copy link
Contributor Author

Added Cross Buttons

image

image

image

@NandiniGera
Copy link
Contributor Author

image

image

image

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit 793e211 into narayan954:master Jul 14, 2023
4 of 5 checks passed
@narayan954 narayan954 linked an issue Jul 14, 2023 that may be closed by this pull request
4 tasks
@narayan954
Copy link
Owner

Thanks for your contribution! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Buttons for Routing back
2 participants