Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the sign up and login page #795

Merged
merged 8 commits into from
Jul 14, 2023

Conversation

Walexz01
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #745

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@narayan954
Copy link
Owner

hi can you please resolve the merge conflicts

@Walexz01
Copy link
Contributor Author

Ok sir

@Walexz01
Copy link
Contributor Author

@narayan954 have resolved the conflicts sir

@narayan954
Copy link
Owner

you didn't resolved it correctly, I'm reverting and resolving myself.

@narayan954
Copy link
Owner

There were several syntax errors, please make sure to test these small things out in future.

@Walexz01
Copy link
Contributor Author

Ok sir

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit fdd47ae into narayan954:master Jul 14, 2023
5 of 6 checks passed
@Walexz01 Walexz01 deleted the refactor__auth-page branch July 14, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Refactor the sign up and login page
2 participants