Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Positioned loader spinner to center of the page #798

Merged
merged 3 commits into from
Jul 14, 2023
Merged

Positioned loader spinner to center of the page #798

merged 3 commits into from
Jul 14, 2023

Conversation

Avinash905
Copy link
Contributor

Closes #742

Description:

Initially, the loader spinner was at the top of the page. So this pr positions the loader spinner to the center of the page.

narayan954
narayan954 approved these changes Jul 14, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit 583264c into narayan954:master Jul 14, 2023
4 of 5 checks passed
@Avinash905
Copy link
Contributor Author

@narayan954 Could you please add level label to this pr?

@narayan954
Copy link
Owner

@narayan954 Could you please add level label to this pr?

sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narayan954 narayan954 narayan954 approved these changes

Assignees
No one assigned
Labels
codepeak level1
Projects
Dummygram
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Position the loading spinner to center of the page
2 participants
@Avinash905 @narayan954