Added Logout and Settings options on profile page #803
Conversation
|
As I can see, you made a mistake of creating a branch from a feature branch instead of the master branch, hence the commits of that feature branch are also reflected on this branch. I can accept this pr by squashing it so that this won't reflect the commit history. Please look after this mistake from the next time. |
|
when you use |
Okay, sorry bro for the mistake. I will not repeat this mistake from next time. |
Yeah sure please give me some time |
|
@narayan954 I have added the logout modal now and it's working fine. Please review this pr. |
src/pages/Profile/index.jsx
Outdated
| import { useSnackbar } from "notistack"; | ||
|
|
||
| const Post = lazy(() => import("../../components/Post")); | ||
| const SideBar = lazy(() => import("../../components/SideBar")); | ||
|
|
||
| export function getModalStyle() { |
There was a problem hiding this comment.
why were you adding this function again if you could just import it?
There was a problem hiding this comment.
I removed it from app.js and then pasted it to the profile page. Later I realized that it is getting used somewhere else also. So forgot to remove it from Profile.js.
src/pages/Profile/index.jsx
Outdated
| }; | ||
| } | ||
|
|
||
| export const useStyles = makeStyles((theme) => ({ |
|
@narayan954 Can you please add the labels? |
right, on it |
|
Thanks! |
Hey, @narayan954 I have successfully added the logout and setting options on the profile page and removed these options from the navbar. Please review my pr and merge it. Thank you!