Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add char limit on different input fields #812

Merged
merged 5 commits into from
Jul 14, 2023

Conversation

Palakkgoyal
Copy link
Contributor

This PR closes issue no. #781
I have added char limit on email, name ,comments and caption. I was not able to find any other. I thought of adding it on password but, it doesn't made much sense to me.

@narayan954 narayan954 linked an issue Jul 14, 2023 that may be closed by this pull request
4 tasks
@narayan954
Copy link
Owner

This PR closes issue no. #781 I have added char limit on email, name ,comments and caption. I was not able to find any other. I thought of adding it on password but, it doesn't made much sense to me.

I think while resolving merge conflict you missed some of the changes. I'm reverting and fixing them

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit e1854d2 into narayan954:master Jul 14, 2023
4 of 5 checks passed
@Palakkgoyal
Copy link
Contributor Author

This PR closes issue no. #781 I have added char limit on email, name ,comments and caption. I was not able to find any other. I thought of adding it on password but, it doesn't made much sense to me.

I think while resolving merge conflict you missed some of the changes. I'm reverting and fixing them

Possible. Thanks for fixing them.

@Palakkgoyal Palakkgoyal deleted the charLimit branch July 15, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[FEATURE] Character limit on caption
2 participants