Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve signup page and fix validation issue #833

Merged
merged 6 commits into from
Jul 18, 2023

Conversation

SubhamB2003
Copy link
Contributor

solves #695

Fixed:
confirm password and password validation issue and adding a scroll option on the signUp page

dummaygramAuth.mp4

@narayan954
Copy link
Owner

solves #695

Fixed: confirm password and password validation issue and adding a scroll option on the signUp page

dummaygramAuth.mp4

Hi @SubhamB2003 UI of login page is getting pretty bad with this, original one is a lot better. You just had to handle the scrolling part for image in signup page. Make it synchronous to login page, just enable scrolling to the form or make the form small in size to fit in.

@SubhamB2003
Copy link
Contributor Author

@narayan954 Hey, is this ok?

dummaygram.mp4

@narayan954
Copy link
Owner

@narayan954 Hey, is this ok?

dummaygram.mp4

yes it is good!, though it's cropped which is perhaps the image's fault as well, as it's too wide.

@SubhamB2003
Copy link
Contributor Author

SubhamB2003 commented Jul 18, 2023

@narayan954 Hey, is this ok?
dummaygram.mp4

yes it is good!, though it's cropped which is perhaps the image's fault as well, as it's too wide.

Yes, so can I update it

If I used fill then it looks like this

image

@narayan954
Copy link
Owner

@narayan954 Hey, is this ok?
dummaygram.mp4

yes it is good!, though it's cropped which is perhaps the image's fault as well, as it's too wide.

Yes, so can I update it

sure, go ahead!

@narayan954
Copy link
Owner

reviewing when I get right back

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! :)

@narayan954 narayan954 linked an issue Jul 18, 2023 that may be closed by this pull request
@narayan954 narayan954 merged commit 7c86244 into narayan954:master Jul 18, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[FEATURE] Improve Sign up page ui
2 participants