Route user profile #835

NandiniGera · 2023-07-15T22:02:27Z

When we click on the username who has made a comment, it routes to that person's profile now!
I've tried working it on many users as well
Completes issue #796

NandiniGera · 2023-07-16T09:12:16Z

Actually, there's one issue in this- when we click on the username, it navigates to that user's profile correctly but on that user's profile it shows my profile pic(the user who has clicked that username who made the comment) only and not the profile pic of the one who made the comment.
I guess the avatar is not fetched right now acc. to the code, I made another issue yesterday on changing the account circle icon with the user's profile pic in the comments, can I correct this with that issue itself?

narayan954 · 2023-07-18T08:54:57Z

Actually, there's one issue in this- when we click on the username, it navigates to that user's profile correctly but on that user's profile it shows my profile pic(the user who has clicked that username who made the comment) only and not the profile pic of the one who made the comment. I guess the avatar is not fetched right now acc. to the code, I made another issue yesterday on changing the account circle icon with the user's profile pic in the comments, can I correct this with that issue itself?

perhaps, it might be due to the fact we're not passing those details in state while navigating, if I'm correct. If we pass the profile pic, it should render, right? Until we refresh the profile page, ofcourse.

narayan954 · 2023-07-18T08:59:24Z

Actually, there's one issue in this- when we click on the username, it navigates to that user's profile correctly but on that user's profile it shows my profile pic(the user who has clicked that username who made the comment) only and not the profile pic of the one who made the comment. I guess the avatar is not fetched right now acc. to the code, I made another issue yesterday on changing the account circle icon with the user's profile pic in the comments, can I correct this with that issue itself?

reason it's showing your profile data is because it's not getting external data and defaulting to logged in user data.
The best way to solve this issue imo is to implement dynamic routes asap for profile, so we can just redirect to the dynamic route of that user, and every other detail should be taken care of independently by that page.

Till then, we can pass the state as in other components to the profile page while naviagting! :D

narayan954

I've marked where the problem currently is

narayan954 · 2023-07-18T11:08:24Z

src/components/Post/CommentDialogBox.jsx

+                <span className="comment-doer-name" onClick={() => {
+                  navigate("/dummygram/profile", {
+                    state: {
+                      name: userComment.content.username,


photo and other details can be passed in this state object

photo and other details can be passed in this state object

I tried doing that, but it didn't work, thats why i removed that code in the updated commit :/

ohhhh, perhaps some other issue, or component getting refreshed on its own. But dont worry now, route has been made dynamic and you dont need to pass these states at all now!! Amazing, isn't it? :)

ohhhh, perhaps some other issue, or component getting refreshed on its own. But dont worry now, route has been made dynamic and you dont need to pass these states at all now!! Amazing, isn't it? :)

Yesss indeed!
Much to learn :)

NandiniGera · 2023-07-18T15:05:39Z

Actually, there's one issue in this- when we click on the username, it navigates to that user's profile correctly but on that user's profile it shows my profile pic(the user who has clicked that username who made the comment) only and not the profile pic of the one who made the comment. I guess the avatar is not fetched right now acc. to the code, I made another issue yesterday on changing the account circle icon with the user's profile pic in the comments, can I correct this with that issue itself?

reason it's showing your profile data is because it's not getting external data and defaulting to logged in user data. The best way to solve this issue imo is to implement dynamic routes asap for profile, so we can just redirect to the dynamic route of that user, and every other detail should be taken care of independently by that page.

Till then, we can pass the state as in other components to the profile page while naviagting! :D

oohhh okayy got it:)

NandiniGera · 2023-07-18T15:31:39Z

I've marked where the problem currently is

Actually, there's one issue in this- when we click on the username, it navigates to that user's profile correctly but on that user's profile it shows my profile pic(the user who has clicked that username who made the comment) only and not the profile pic of the one who made the comment. I guess the avatar is not fetched right now acc. to the code, I made another issue yesterday on changing the account circle icon with the user's profile pic in the comments, can I correct this with that issue itself?

perhaps, it might be due to the fact we're not passing those details in state while navigating, if I'm correct. If we pass the profile pic, it should render, right? Until we refresh the profile page, ofcourse.

I added the state objects again, after refreshing it shows that user's profile pic just for one sec and then back again it shows my profile pic :/

narayan954 · 2023-07-18T17:00:30Z

I've marked where the problem currently is

Actually, there's one issue in this- when we click on the username, it navigates to that user's profile correctly but on that user's profile it shows my profile pic(the user who has clicked that username who made the comment) only and not the profile pic of the one who made the comment. I guess the avatar is not fetched right now acc. to the code, I made another issue yesterday on changing the account circle icon with the user's profile pic in the comments, can I correct this with that issue itself?

perhaps, it might be due to the fact we're not passing those details in state while navigating, if I'm correct. If we pass the profile pic, it should render, right? Until we refresh the profile page, ofcourse.

I added the state objects again, after refreshing it shows that user's profile pic just for one sec and then back again it shows my profile pic :/

listen,no need to worry now, we just implemented the major feature of dynamic profile routes, credits to @Palakkgoyal .
So you can just redirect to the correct username, rest is handled on its own :D

NandiniGera · 2023-07-18T17:28:14Z

I've marked where the problem currently is

Actually, there's one issue in this- when we click on the username, it navigates to that user's profile correctly but on that user's profile it shows my profile pic(the user who has clicked that username who made the comment) only and not the profile pic of the one who made the comment. I guess the avatar is not fetched right now acc. to the code, I made another issue yesterday on changing the account circle icon with the user's profile pic in the comments, can I correct this with that issue itself?

perhaps, it might be due to the fact we're not passing those details in state while navigating, if I'm correct. If we pass the profile pic, it should render, right? Until we refresh the profile page, ofcourse.

I added the state objects again, after refreshing it shows that user's profile pic just for one sec and then back again it shows my profile pic :/

listen,no need to worry now, we just implemented the major feature of dynamic profile routes, credits to @Palakkgoyal . So you can just redirect to the correct username, rest is handled on its own :D

okayy thats great!

narayan954 · 2023-07-20T04:18:30Z

I've marked where the problem currently is

Actually, there's one issue in this- when we click on the username, it navigates to that user's profile correctly but on that user's profile it shows my profile pic(the user who has clicked that username who made the comment) only and not the profile pic of the one who made the comment. I guess the avatar is not fetched right now acc. to the code, I made another issue yesterday on changing the account circle icon with the user's profile pic in the comments, can I correct this with that issue itself?

perhaps, it might be due to the fact we're not passing those details in state while navigating, if I'm correct. If we pass the profile pic, it should render, right? Until we refresh the profile page, ofcourse.

I added the state objects again, after refreshing it shows that user's profile pic just for one sec and then back again it shows my profile pic :/

listen,no need to worry now, we just implemented the major feature of dynamic profile routes, credits to @Palakkgoyal . So you can just redirect to the correct username, rest is handled on its own :D

okayy thats great!

Hi @NandiniGera is there any blocker?

NandiniGera · 2023-07-20T08:00:22Z

I've marked where the problem currently is

Actually, there's one issue in this- when we click on the username, it navigates to that user's profile correctly but on that user's profile it shows my profile pic(the user who has clicked that username who made the comment) only and not the profile pic of the one who made the comment. I guess the avatar is not fetched right now acc. to the code, I made another issue yesterday on changing the account circle icon with the user's profile pic in the comments, can I correct this with that issue itself?

perhaps, it might be due to the fact we're not passing those details in state while navigating, if I'm correct. If we pass the profile pic, it should render, right? Until we refresh the profile page, ofcourse.

I added the state objects again, after refreshing it shows that user's profile pic just for one sec and then back again it shows my profile pic :/

listen,no need to worry now, we just implemented the major feature of dynamic profile routes, credits to @Palakkgoyal . So you can just redirect to the correct username, rest is handled on its own :D

okayy thats great!

Hi @NandiniGera is there any blocker?

Actually I updated the code, but it isn't working :/
I've added the commit

narayan954 · 2023-07-20T13:09:18Z

I've marked where the problem currently is

Actually, there's one issue in this- when we click on the username, it navigates to that user's profile correctly but on that user's profile it shows my profile pic(the user who has clicked that username who made the comment) only and not the profile pic of the one who made the comment. I guess the avatar is not fetched right now acc. to the code, I made another issue yesterday on changing the account circle icon with the user's profile pic in the comments, can I correct this with that issue itself?

perhaps, it might be due to the fact we're not passing those details in state while navigating, if I'm correct. If we pass the profile pic, it should render, right? Until we refresh the profile page, ofcourse.

I added the state objects again, after refreshing it shows that user's profile pic just for one sec and then back again it shows my profile pic :/

listen,no need to worry now, we just implemented the major feature of dynamic profile routes, credits to @Palakkgoyal . So you can just redirect to the correct username, rest is handled on its own :D

okayy thats great!

Hi @NandiniGera is there any blocker?

Actually I updated the code, but it isn't working :/ I've added the commit

aight checking

narayan954

looks good to me!

NandiniGera added 3 commits July 16, 2023 03:29

Route added

8980cf6

hover pointer

62931b7

updated code

3c48b2d

NandiniGera added 2 commits July 17, 2023 13:50

Merge branch 'master' into RouteUserProfile

5db7d80

Merge branch 'master' into RouteUserProfile

3ac83d4

narayan954 requested changes Jul 18, 2023

View reviewed changes

Merge branch 'master' into RouteUserProfile

00b0858

Merge branch 'master' into RouteUserProfile

7f4f3e2

narayan954 linked an issue Jul 18, 2023 that may be closed by this pull request

User Profile from Comments #796

Closed

4 tasks

Merge branch 'master' into RouteUserProfile

a61cfd9

narayan954 mentioned this pull request Jul 18, 2023

Comment routing #853

Closed

4 tasks

Merge branch 'master' into RouteUserProfile

b107b03

narayan954 and others added 2 commits July 20, 2023 09:48

Merge branch 'master' into RouteUserProfile

b53ea0b

route updated

c0fcc19

NandiniGera and others added 2 commits July 20, 2023 17:53

Merge branch 'master' into RouteUserProfile

393a81a

Merge branch 'master' into RouteUserProfile

e1e23f2

narayan954 added 3 commits July 20, 2023 21:20

Merge branch 'master' into RouteUserProfile

d2b066f

Merge branch 'master' into RouteUserProfile

46f4cda

debugged and fixed stuffs

4d84098

narayan954 approved these changes Jul 20, 2023

View reviewed changes

narayan954 merged commit 8040a7c into narayan954:master Jul 20, 2023
4 of 5 checks passed

narayan954 added level1 codepeak labels Jul 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Route user profile #835

Route user profile #835

NandiniGera commented Jul 15, 2023 •

edited

Loading

NandiniGera commented Jul 16, 2023

narayan954 commented Jul 18, 2023

narayan954 commented Jul 18, 2023 •

edited

Loading

narayan954 left a comment

narayan954 Jul 18, 2023

NandiniGera Jul 18, 2023

narayan954 Jul 18, 2023

NandiniGera Jul 18, 2023

NandiniGera commented Jul 18, 2023

NandiniGera commented Jul 18, 2023

narayan954 commented Jul 18, 2023 •

edited

Loading

NandiniGera commented Jul 18, 2023

narayan954 commented Jul 20, 2023

NandiniGera commented Jul 20, 2023

narayan954 commented Jul 20, 2023

narayan954 left a comment

Route user profile #835

Route user profile #835

Conversation

NandiniGera commented Jul 15, 2023 • edited Loading

NandiniGera commented Jul 16, 2023

narayan954 commented Jul 18, 2023

narayan954 commented Jul 18, 2023 • edited Loading

narayan954 left a comment

Choose a reason for hiding this comment

narayan954 Jul 18, 2023

Choose a reason for hiding this comment

NandiniGera Jul 18, 2023

Choose a reason for hiding this comment

narayan954 Jul 18, 2023

Choose a reason for hiding this comment

NandiniGera Jul 18, 2023

Choose a reason for hiding this comment

NandiniGera commented Jul 18, 2023

NandiniGera commented Jul 18, 2023

narayan954 commented Jul 18, 2023 • edited Loading

NandiniGera commented Jul 18, 2023

narayan954 commented Jul 20, 2023

NandiniGera commented Jul 20, 2023

narayan954 commented Jul 20, 2023

narayan954 left a comment

Choose a reason for hiding this comment

NandiniGera commented Jul 15, 2023 •

edited

Loading

narayan954 commented Jul 18, 2023 •

edited

Loading

narayan954 commented Jul 18, 2023 •

edited

Loading