-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initial commitlint configuration ✨ #920
Conversation
…nt on push and pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Nishitbaria! for creating this pull request and contributing to Dummygram! 💗
The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there Nishitbaria!, congratulations on your first pull request :)
hey @narayan954 please review my Pr |
Hi @Nishitbaria I can't verify it with instruction you provided. Can you check again? Also, I am not sure if that's because my commit message was a valid one. You haven't described valid/invalid commit message this'd filter. Also, you haven't updated the contribution guideline. Can you please check these? |
@narayan954 ,I am updating in few minutes |
Hey @narayan954 I have updated contribution. md and also added an example : |
Thanks a lot @Nishitbaria , can you help with this ? |
by running this command |
Hey @narayan954, there's one thing you can do. Could you please delete your current clone and re-clone it? I have fixed the changes. |
oh alright! |
Thank you! It works!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Related Issues:
Closes #898
Description:
This pull request introduces the integration of Commitlint into the project. Commitlint is a powerful tool that enforces a standardized format for commit messages, ensuring consistency and clarity across all contributions. By adhering to a common commit message convention, we can enhance collaboration, simplify code review processes, and facilitate better changelog generation.
Sure! To add instructions for committing using commitlint, you can include the following guidelines along with examples of valid and invalid commit messages.
Commit Message Guidelines using Commitlint
We follow a standardized commit message format using Commitlint to ensure consistency and clarity in our commit history. Each commit message should adhere to the following guidelines:
Type: The commit type must be one of the following:
feat
: A new feature or enhancement.fix
: A bug fix.docs
: Documentation changes.style
: Code style changes (e.g., formatting, semicolons).refactor
: Code refactorings with no feature changes or bug fixes.test
: Adding or improving tests.chore
: General maintenance tasks, build changes, etc.Scope (Optional): The scope provides context for the commit, indicating the specific part of the project being affected. Use a short description in lowercase (e.g.,
auth
,navbar
,README
).Description: A brief and meaningful description of the changes made. Start with a capital letter and use the imperative mood (e.g., "Add new feature" instead of "Added new feature").
Issue reference (Optional): Include the issue number associated with the commit (e.g.,
#123
).Examples:
Valid Commit Messages:
feat: Add user authentication feature
fix(auth): Resolve login page redirect issue
docs: Update installation instructions
style: Format code according to project guidelines
refactor(navbar): Improve responsiveness
test: Add unit tests for API endpoints
chore: Update dependencies to latest versions
fix: Handle edge case in data processing (#456)
Invalid Commit Messages:
Added new stuff
Fixed a bug
Updated code
auth feature update
chore: fixed some stuff
Commit Example with Commitlint:
git commit -m "feat(auth): Implement user signup process (#789)"
Remember to run
commitlint
before pushing your changes to ensure your commit messages meet the guidelines.By following these guidelines, we can maintain a clean commit history that is easy to understand and helps us effectively track changes. If you have any questions or need further assistance, feel free to ask! Happy contributing!