changes made in eye icon

[shruuti321]

Closes #907
I have restyled the eye icon by changing background color,icon color and increasing icon size in both login and signup pages.
Kindly review and merge

[github-actions]

Thank you shruuti321! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

[shruuti321]

@narayan954 please review the pr

[narayan954]

Closes #907 I have restyled the eye icon by changing background color,icon color and increasing icon size in both login and signup pages. Kindly review and merge

Hi @shruuti321 thanks for enhancing it, but as you see in the third picture, it's not centered properly, can you try to fix that, please?

[shruuti321]

@narayan954
Yes I tried several properties like margin-left:auto,margin-right:auto, text-align:center,align-items:center
but nothing is working.
using display:flex got me this

but this has disturbed the alignment in signup page

So kindly suggest whether to make this change or keep it as previous

[narayan954]

@narayan954 Yes I tried several properties like margin-left:auto,margin-right:auto, text-align:center,align-items:center but nothing is working. using display:flex got me this

but this has disturbed the alignment in signup page So kindly suggest whether to make this change or keep it as previous

Does separating this css or adding inline css just for this element work? If not, then it's alright, I'll allow this

[shruuti321]

@narayan954 Yes I tried several properties like margin-left:auto,margin-right:auto, text-align:center,align-items:center but nothing is working. using display:flex got me this
but this has disturbed the alignment in signup page So kindly suggest whether to make this change or keep it as previous

Does separating this css or adding inline css just for this element work? If not, then it's alright, I'll allow this

Not working, tried that as well

[narayan954]

@narayan954 Yes I tried several properties like margin-left:auto,margin-right:auto, text-align:center,align-items:center but nothing is working. using display:flex got me this
but this has disturbed the alignment in signup page So kindly suggest whether to make this change or keep it as previous

Does separating this css or adding inline css just for this element work? If not, then it's alright, I'll allow this

Not working, tried that as well

Alright

[narayan954]

looks good to me!

[shruuti321]

@narayan954 may i know if you have approved the changes as proposed previously or the recent ones?
I havent created a pull request for the last change

@narayan954 Yes I tried several properties like margin-left:auto,margin-right:auto, text-align:center,align-items:center but nothing is working. using display:flex got me this
but this has disturbed the alignment in signup page So kindly suggest whether to make this change or keep it as previous

Does separating this css or adding inline css just for this element work? If not, then it's alright, I'll allow this

Not working, tried that as well

May i know if you have approved the changes I have made earlier or the recent ones, because I haven't created a pull request for the recent changes yet

[narayan954]

@narayan954 may i know if you have approved the changes as proposed previously or the recent ones?
I havent created a pull request for the last change

@narayan954 Yes I tried several properties like margin-left:auto,margin-right:auto, text-align:center,align-items:center but nothing is working. using display:flex got me this
but this has disturbed the alignment in signup page So kindly suggest whether to make this change or keep it as previous

Does separating this css or adding inline css just for this element work? If not, then it's alright, I'll allow this

Not working, tried that as well

May i know if you have approved the changes I have made earlier or the recent ones, because I haven't created a pull request for the recent changes yet

I went with the original changes.

Also fyi you don't need to create a new pull request if you want to add changes to this pr... you can directly commit and push and this pr will be updated with the commits automatically :)

[shruuti321]

@narayan954 may i know if you have approved the changes as proposed previously or the recent ones?
I havent created a pull request for the last change

@narayan954 Yes I tried several properties like margin-left:auto,margin-right:auto, text-align:center,align-items:center but nothing is working. using display:flex got me this
but this has disturbed the alignment in signup page So kindly suggest whether to make this change or keep it as previous

Does separating this css or adding inline css just for this element work? If not, then it's alright, I'll allow this

Not working, tried that as well

May i know if you have approved the changes I have made earlier or the recent ones, because I haven't created a pull request for the recent changes yet

I went with the original changes.

Also fyi you don't need to create a new pull request if you want to add changes to this pr... you can directly commit and push and this pr will be updated with the commits automatically :)

Okay! Thanks a lot