Fix loader bug of profile page #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
4 tasks
narayan954
reviewed
Jul 25, 2023
| avatar: doc.data().photoURL, | ||
| uid: doc.data().uid, | ||
| }); | ||
| if(snapshot.exists){ |
There was a problem hiding this comment.
This is perhaps not a valid condition and hence profile was being forwarded to 404 page everytime instead.
There was a problem hiding this comment.
I had to revert this, sort of, to fix this
|
Is it? let me check. |
yes, you may re add this on your localhost and it shouldn't work! ;-; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue no. #883
I have added the condition for finding user and if not found then show 404