-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Story feature #956
Story feature #956
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Palakkgoyal! for creating this pull request and contributing to Dummygram! 💗
The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some issues I noticed, anyone can delete your story, only 1 story limit, also this story limit wont be refreshed even after time bound as we have to visit profile page first, when that component loads then only limit is refreshed. When on profile page if we create story, it wont show up, we have to go to back and back to profile page. Also, in case of no story, clicking on pfp does nothing, but that has a cursor pointer(bad ux). Stories without pictures, seem to be buggy I believe or maybe its a browser issue. We get a broken page in that case.
Overall, these issues are meant for further improvement, so I am merging this pr and we can fix them later!
Thanks for your contribution! :) |
This PR closes #152
I have created a story feature that will disappear after 24 hours without using cloud functions.