Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story feature #956

Merged
merged 5 commits into from
Jul 25, 2023
Merged

Story feature #956

merged 5 commits into from
Jul 25, 2023

Conversation

Palakkgoyal
Copy link
Contributor

@Palakkgoyal Palakkgoyal commented Jul 25, 2023

This PR closes #152
I have created a story feature that will disappear after 24 hours without using cloud functions.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Palakkgoyal! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some issues I noticed, anyone can delete your story, only 1 story limit, also this story limit wont be refreshed even after time bound as we have to visit profile page first, when that component loads then only limit is refreshed. When on profile page if we create story, it wont show up, we have to go to back and back to profile page. Also, in case of no story, clicking on pfp does nothing, but that has a cursor pointer(bad ux). Stories without pictures, seem to be buggy I believe or maybe its a browser issue. We get a broken page in that case.
image

Overall, these issues are meant for further improvement, so I am merging this pr and we can fix them later!

@narayan954 narayan954 merged commit f07c105 into narayan954:master Jul 25, 2023
4 of 5 checks passed
@narayan954
Copy link
Owner

Thanks for your contribution! :)

@Palakkgoyal
Copy link
Contributor Author

some issues I noticed, anyone can delete your story, only 1 story limit, also this story limit wont be refreshed even after time bound as we have to visit profile page first, when that component loads then only limit is refreshed. When on profile page if we create story, it wont show up, we have to go to back and back to profile page. Also, in case of no story, clicking on pfp does nothing, but that has a cursor pointer(bad ux). Stories without pictures, seem to be buggy I believe or maybe its a browser issue. We get a broken page in that case. image

Overall, these issues are meant for further improvement, so I am merging this pr and we can fix them later!

Yes, Its a big issue that other person can also delete story and I missed to check it.
Initially, I have given only 1 story limit for the sake of simplicity.
Yes, about the time bound thing I told you this before, this is the main downside of not using cloud.
I tried to show it up instantly on the profile page but I was not able to do that at this point of time.
I made it such that it does nothing if there is no story but, I think now we can show the dialog box for profile image as before if no story exists.

@narayan954
Copy link
Owner

some issues I noticed, anyone can delete your story, only 1 story limit, also this story limit wont be refreshed even after time bound as we have to visit profile page first, when that component loads then only limit is refreshed. When on profile page if we create story, it wont show up, we have to go to back and back to profile page. Also, in case of no story, clicking on pfp does nothing, but that has a cursor pointer(bad ux). Stories without pictures, seem to be buggy I believe or maybe its a browser issue. We get a broken page in that case. image
Overall, these issues are meant for further improvement, so I am merging this pr and we can fix them later!

Yes, Its a big issue that other person can also delete story and I missed to check it. Initially, I have given only 1 story limit for the sake of simplicity. Yes, about the time bound thing I told you this before, this is the main downside of not using cloud. I tried to show it up instantly on the profile page but I was not able to do that at this point of time. I made it such that it does nothing if there is no story but, I think now we can show the dialog box for profile image as before if no story exists.

right * n , I agree on this!

@Palakkgoyal Palakkgoyal deleted the storyFeature branch July 31, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[FEATURE] User Story feature
2 participants