Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed comment box error #968

Merged
merged 5 commits into from
Jul 25, 2023
Merged

Conversation

Palakkgoyal
Copy link
Contributor

This PR fixes issue no. #891
The problem occured because the elements were wrapped in a p tag and this is not validated by DOM. Due to the use of mui tag it was tricky to find which tag is p tag but after doing some trials I got the source and fixed it by replacing it with a div. Now the console do not throw any error on clicking the comment button on post nav.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Palakkgoyal! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@narayan954 narayan954 linked an issue Jul 25, 2023 that may be closed by this pull request
4 tasks
@narayan954
Copy link
Owner

This PR fixes issue no. #891 The problem occured because the elements were wrapped in a p tag and this is not validated by DOM. Due to the use of mui tag it was tricky to find which tag is p tag but after doing some trials I got the source and fixed it by replacing it with a div. Now the console do not throw any error on clicking the comment button on post nav.

I'm glad how you found it :) . So this error lies on their component itself, right? Maybe if their repo's open source we can contribute XD

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit dacf4e8 into narayan954:master Jul 25, 2023
3 of 4 checks passed
@Palakkgoyal
Copy link
Contributor Author

This PR fixes issue no. #891 The problem occured because the elements were wrapped in a p tag and this is not validated by DOM. Due to the use of mui tag it was tricky to find which tag is p tag but after doing some trials I got the source and fixed it by replacing it with a div. Now the console do not throw any error on clicking the comment button on post nav.

I'm glad how you found it :) . So this error lies on their component itself, right? Maybe if their repo's open source we can contribute XD

Yupss XD

@Palakkgoyal Palakkgoyal deleted the errorConsole branch July 31, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Error in the console
2 participants