-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed comment box error #968
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Palakkgoyal! for creating this pull request and contributing to Dummygram! 💗
The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀
I'm glad how you found it :) . So this error lies on their component itself, right? Maybe if their repo's open source we can contribute XD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Yupss XD |
This PR fixes issue no. #891
The problem occured because the elements were wrapped in a p tag and this is not validated by DOM. Due to the use of mui tag it was tricky to find which tag is p tag but after doing some trials I got the source and fixed it by replacing it with a div. Now the console do not throw any error on clicking the comment button on post nav.