-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post liker list #975
Post liker list #975
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Palakkgoyal! for creating this pull request and contributing to Dummygram! 💗
The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀
won't a modal look better @Palakkgoyal ? instead of separate page for likes? |
Your approach is good, but I doubt if we really needed a separate page to show this small data? |
Yes, you are right I initially go for the modal but I faced some problems like on mobile if user click back to close the modal(instead of the close icon) then they get out of the website. But Okay, I will try that approach again and resolve the issues. |
ohhh, I think Vijaylakshmi made the frontend part for this, you can try to take help from her if you still face issue :) |
Oh yes! she did hey @VijayalakshmiGanesh would you like to share about that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Palakkgoyal can you please add a bit more responsiveness(font's too big,overflowing)? Else it's fine.
Yes, sure. |
I have added some responsive. Can you please check and is there anything else I can do? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great to me!
This PR closes #370
![Screenshot 2023-07-26 125845](https://private-user-images.githubusercontent.com/116902573/256151327-8f89a76d-8397-4c6d-8019-9683a3583db3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI4NDA5MjIsIm5iZiI6MTcyMjg0MDYyMiwicGF0aCI6Ii8xMTY5MDI1NzMvMjU2MTUxMzI3LThmODlhNzZkLTgzOTctNGM2ZC04MDE5LTk2ODNhMzU4M2RiMy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODA1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgwNVQwNjUwMjJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01YmQ1MGM0YjkwOTllZTlmMzYyODNjYzI2MWMwZDNhMjE1NjYyNTEzZjdkODNiMWJiZjZkMTZmZDFiMWI3MDllJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.Az5_r9lnTDY-GJJ_34HZ0a9vclPTMcynn4g4c9o_-Yk)
I have added a new page to show post likes and it is responsive.