Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post liker list #975

Merged
merged 14 commits into from
Jul 29, 2023
Merged

Post liker list #975

merged 14 commits into from
Jul 29, 2023

Conversation

Palakkgoyal
Copy link
Contributor

@Palakkgoyal Palakkgoyal commented Jul 26, 2023

This PR closes #370
I have added a new page to show post likes and it is responsive.
Screenshot 2023-07-26 125845

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Palakkgoyal! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@narayan954
Copy link
Owner

This PR closes issue no. #370 I have added a new page to show post likes and it is responsive. Screenshot 2023-07-26 125845

won't a modal look better @Palakkgoyal ? instead of separate page for likes?
Like this?
image

@narayan954
Copy link
Owner

Your approach is good, but I doubt if we really needed a separate page to show this small data?

@Palakkgoyal
Copy link
Contributor Author

This PR closes issue no. #370 I have added a new page to show post likes and it is responsive. Screenshot 2023-07-26 125845

won't a modal look better @Palakkgoyal ? instead of separate page for likes? Like this? image

Yes, you are right I initially go for the modal but I faced some problems like on mobile if user click back to close the modal(instead of the close icon) then they get out of the website. But Okay, I will try that approach again and resolve the issues.

@narayan954
Copy link
Owner

This PR closes issue no. #370 I have added a new page to show post likes and it is responsive. Screenshot 2023-07-26 125845

won't a modal look better @Palakkgoyal ? instead of separate page for likes? Like this? image

Yes, you are right I initially go for the modal but I faced some problems like on mobile if user click back to close the modal(instead of the close icon) then they get out of the website. But Okay, I will try that approach again and resolve the issues.

ohhh, I think Vijaylakshmi made the frontend part for this, you can try to take help from her if you still face issue :)

@Palakkgoyal
Copy link
Contributor Author

This PR closes issue no. #370 I have added a new page to show post likes and it is responsive. Screenshot 2023-07-26 125845

won't a modal look better @Palakkgoyal ? instead of separate page for likes? Like this? image

Yes, you are right I initially go for the modal but I faced some problems like on mobile if user click back to close the modal(instead of the close icon) then they get out of the website. But Okay, I will try that approach again and resolve the issues.

ohhh, I think Vijaylakshmi made the frontend part for this, you can try to take help from her if you still face issue :)

Oh yes! she did hey @VijayalakshmiGanesh would you like to share about that?

@Palakkgoyal
Copy link
Contributor Author

Hey, I did the required changes and also made it darkmode compatible.
Screenshot 2023-07-28 154521
Screenshot 2023-07-28 154554

@narayan954
Copy link
Owner

Hey, I did the required changes and also made it darkmode compatible. Screenshot 2023-07-28 154521 Screenshot 2023-07-28 154554

awesome! merging it asap!

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Palakkgoyal can you please add a bit more responsiveness(font's too big,overflowing)? Else it's fine.
image

@Palakkgoyal
Copy link
Contributor Author

Yes, sure.

@Palakkgoyal
Copy link
Contributor Author

I have added some responsive. Can you please check and is there anything else I can do?

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me!

@narayan954 narayan954 merged commit b774104 into narayan954:master Jul 29, 2023
4 of 5 checks passed
@Palakkgoyal Palakkgoyal deleted the postLikerList branch July 31, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[FEATURE] Show post likers list
2 participants