Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add profile grid view #983

Merged
merged 8 commits into from
Jul 28, 2023
Merged

add profile grid view #983

merged 8 commits into from
Jul 28, 2023

Conversation

Palakkgoyal
Copy link
Contributor

@Palakkgoyal Palakkgoyal commented Jul 26, 2023 •
edited by narayan954
Loading

This PR closes #941
I have added a grid view on profile page. When user click on any image they will be taken to the post view page of that particular post.

github-actions[bot]
github-actions bot reviewed Jul 26, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Palakkgoyal! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@narayan954
Copy link
Owner

Hi @Palakkgoyal I've been meaning to suggest 2 things to you regarding this project and open source

  • while creating pr, you can use phrase like solves #99999 or fix #9999 or fixes #7799989 (there are lot many like this, available on web) . using these phrases anywhere in comment of the pr links the pr automatically to that issue and hence closes the issue automatically on successfull merge. I'm editting this pr as well to show u an example. This is really convenient.
  • There's a script pretty in the package.json in our project. Using that script you can automatically format all the files in our project(though there're some missing configuration that I will fix).Try using that script before committing to format everything.
    To use that, run npm run pretty

narayan954
narayan954 reviewed Jul 26, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is breaking the row mode(or column perhaps) of main/home feed, can you please have a look?

src/pages/Profile/feed/index.css Outdated Show resolved Hide resolved
@Palakkgoyal Palakkgoyal force-pushed the gridView branch 2 times, most recently from b07c484 to b67f703 Compare July 28, 2023 08:49
@Palakkgoyal Palakkgoyal reopened this Jul 28, 2023
narayan954
narayan954 approved these changes Jul 28, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit 7bf55cd into narayan954:master Jul 28, 2023
3 of 4 checks passed
@narayan954
Copy link
Owner

i added some more changes, lmk how it looks now, cause I'm feeling happy after playing with css and able to not break Ui (perhaps) :')

@narayan954
Copy link
Owner

image
image

@Palakkgoyal
Copy link
Contributor Author

Yes, It looks really better than before.

@Palakkgoyal Palakkgoyal deleted the gridView branch July 31, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@narayan954 narayan954 narayan954 approved these changes

Assignees
No one assigned
Labels
codepeak level2
Projects
Dummygram
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Adding a grid view on profile
2 participants
@Palakkgoyal @narayan954