Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix 981 #996

Merged
merged 10 commits into from
Jul 28, 2023
Merged

Bug fix 981 #996

merged 10 commits into from
Jul 28, 2023

Conversation

biplavmz
Copy link
Contributor

image

bug fix for chat close #981

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you biplavmz! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@narayan954
Copy link
Owner

image bug fix for chat close #981

That's not an ideal place, put it at top left or top right of the chat section

@biplavmz
Copy link
Contributor Author

This is ok or we need to change the image place
image

@narayan954
Copy link
Owner

This is ok or we need to change the image place image

checking!, btw it'd be better if it doesn't align parallel with the showing last 20 and messages. I mean it should stand out as an exit button

@narayan954 narayan954 merged commit 9b9faef into narayan954:master Jul 28, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

🐛There is no close button for chat
2 participants