Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search user #998

Merged
merged 10 commits into from
Jul 27, 2023
Merged

Search user #998

merged 10 commits into from
Jul 27, 2023

Conversation

Palakkgoyal
Copy link
Contributor

@Palakkgoyal Palakkgoyal commented Jul 27, 2023

This PR closes #755
I have added a search user functionality with a debounced function so that search will only happen after 2s of user stop typing to decrease fetch requests. The search will fetch 7 users at a time. If someone click on the user li they will be navigated to that user profile.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Palakkgoyal! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks awesome to me!

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome to me, but I think you've mistakenly solved #755 instead instead of moving it to navbar XD

@narayan954 narayan954 merged commit 225f821 into narayan954:master Jul 27, 2023
4 of 5 checks passed
@Palakkgoyal
Copy link
Contributor Author

Yes, might be cause I was confused as we were querying for user but that will not suit in the navbar and in our discussion you mentioned that it might need some different logic. I thought you are saying about fetching data😅. So, I did that changes.
Sorry @anamika7153 for mistakenly taking your assigned issue.

@narayan954
Copy link
Owner

narayan954 commented Jul 27, 2023

Yes, might be cause I was confused as we were querying for user but that will not suit in the navbar and in our discussion you mentioned that it might need some different logic. I thought you are saying about fetching datasweat_smile. So, I did that changes. Sorry @anamika7153 for mistakenly taking your assigned issue.

Yes, it's alright! Btw still query is behaving unwell because some users have name field and some have displayname field
and query is only searching on name field... thinking to modify all of them to displayname

@narayan954
Copy link
Owner

Yes, might be cause I was confused as we were querying for user but that will not suit in the navbar and in our discussion you mentioned that it might need some different logic. I thought you are saying about fetching datasweat_smile. So, I did that changes. Sorry @anamika7153 for mistakenly taking your assigned issue.

Yes, it's alright! Btw still query is behaving unwell because some users have name field and some have displayname field and query is only searching on name field... thinking to modify all of them to displayname

and I am giving that moving issu to @anamika7153 actually, maybe I think we can add a search icon or something on navbar nah?

@Palakkgoyal
Copy link
Contributor Author

Yes, might be cause I was confused as we were querying for user but that will not suit in the navbar and in our discussion you mentioned that it might need some different logic. I thought you are saying about fetching datasweat_smile. So, I did that changes. Sorry @anamika7153 for mistakenly taking your assigned issue.

Yes, it's alright! Btw still query is behaving unwell because some users have name field and some have displayname field and query is only searching on name field... thinking to modify all of them to displayname

Yes, that was a problem for me as well. So, I picked the name field. Moving to completely one field would be a good choice.

@Palakkgoyal
Copy link
Contributor Author

Yes, might be cause I was confused as we were querying for user but that will not suit in the navbar and in our discussion you mentioned that it might need some different logic. I thought you are saying about fetching datasweat_smile. So, I did that changes. Sorry @anamika7153 for mistakenly taking your assigned issue.

Yes, it's alright! Btw still query is behaving unwell because some users have name field and some have displayname field and query is only searching on name field... thinking to modify all of them to displayname

and I am giving that moving issu to @anamika7153 actually, maybe I think we can add a search icon or something on navbar nah?

Yes, I think we should just add a icon to navbar. But, what will happen on the mobile view. As there will be two icon one on navbar and one on the below bar.

@narayan954
Copy link
Owner

sidebar search is going to be eliminated actually

@narayan954
Copy link
Owner

Yes, might be cause I was confused as we were querying for user but that will not suit in the navbar and in our discussion you mentioned that it might need some different logic. I thought you are saying about fetching datasweat_smile. So, I did that changes. Sorry @anamika7153 for mistakenly taking your assigned issue.

Yes, it's alright! Btw still query is behaving unwell because some users have name field and some have displayname field and query is only searching on name field... thinking to modify all of them to displayname

and I am giving that moving issu to @anamika7153 actually, maybe I think we can add a search icon or something on navbar nah?

Yes, I think we should just add a icon to navbar. But, what will happen on the mobile view. As there will be two icon one on navbar and one on the below bar.

done lol!

@Palakkgoyal Palakkgoyal deleted the searchUser branch July 31, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[BUG]: Search operation is case sensitive and inefficient
2 participants