-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search user #998
Search user #998
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Palakkgoyal! for creating this pull request and contributing to Dummygram! 💗
The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks awesome to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome to me, but I think you've mistakenly solved #755 instead instead of moving it to navbar XD
Yes, might be cause I was confused as we were querying for user but that will not suit in the navbar and in our discussion you mentioned that it might need some different logic. I thought you are saying about fetching data😅. So, I did that changes. |
Yes, it's alright! Btw still query is behaving unwell because some users have name field and some have displayname field |
and I am giving that moving issu to @anamika7153 actually, maybe I think we can add a search icon or something on navbar nah? |
Yes, that was a problem for me as well. So, I picked the name field. Moving to completely one field would be a good choice. |
Yes, I think we should just add a icon to navbar. But, what will happen on the mobile view. As there will be two icon one on navbar and one on the below bar. |
sidebar search is going to be eliminated actually |
done lol! |
This PR closes #755
I have added a search user functionality with a debounced function so that search will only happen after 2s of user stop typing to decrease fetch requests. The search will fetch 7 users at a time. If someone click on the user li they will be navigated to that user profile.