Use cl-lib function instead of cl.el #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And remove eval-when-compile for using cl-lib function.
narendraj9
reviewed
Apr 2, 2017
| @@ -177,8 +176,8 @@ not balance at point." | |||
| (neg-amounts (seq-filter (lambda (n) | |||
| (not (< 0 n))) | |||
| amounts)) | |||
| (pos-amounts-sum (reduce '+ pos-amounts :initial-value 0.0)) | |||
| (neg-amounts-sum (reduce '+ neg-amounts :initial-value 0.0)) | |||
| (pos-amounts-sum (cl-reduce '+ pos-amounts :initial-value 0.0)) | |||
There was a problem hiding this comment.
I just looked at the files cl-lib.el and cl-seq.el. The function cl-reduce is defined in cl-seq.el and cl-seq has not been required in cl-lib.el. How is it happening that we have cl-reduce (which is also being used by reduce) loaded when we require only cl-lib.el?
There was a problem hiding this comment.
Look at the bottom of the cl-lib.el, you will find the expression
(unless (load "cl-loaddefs" 'noerror 'quiet)
;; When bootstrapping, cl-loaddefs hasn't been built yet!
(require 'cl-macs)
(require 'cl-seq))Basically it is trying to load cl-loaddefs (which in turn loads cl-seq) if that fails it loads cl-seq directly
There was a problem hiding this comment.
Okay. So, the requires are at the end of the file. Thanks :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And remove eval-when-compile for using cl-lib function.