Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document blocks role / usage #6

Open
drzraf opened this issue Aug 25, 2022 · 5 comments
Open

document blocks role / usage #6

drzraf opened this issue Aug 25, 2022 · 5 comments

Comments

@drzraf
Copy link
Contributor

drzraf commented Aug 25, 2022

So far, we have:

  • cp-timeline/content-timeline inside includes/cool-timeline-block
  • cp-timeline/content-timeline-child inside includes/cool-timeline-block
  • cooltimeline/timeline-block inside includes/gutenberg-block

Do you mind defining/documenting/formalizing this, why was is setup that way and what would be a possibly better organization without breaking existing namespacing?
It's also a bit confusing that that gutenberg-block directory contains the blocks namespaced cooltimeline, while the cool-timeline-block directory contains two blocks with the cp-timeline namespace.

@drzraf
Copy link
Contributor Author

drzraf commented Mar 28, 2023

ping?

@sque89
Copy link

sque89 commented Mar 29, 2023

it would be very helpful to get an answer on this. Our main problem is, that the sources in gutenberg-block are not minified but i don't find where they are actually build.

@narinder9
Copy link
Owner

Hi @drzraf ,@sque89,

The reason why we cannot change the folder structure/namespace is because the gutenberg-block directory still contains the deprecated version of the timeline block, and some users are still using this older version. Therefore, we need to maintain the existing folder structure to ensure compatibility for those users. We are still searching user migration solutions.

@sque89
Copy link

sque89 commented Mar 29, 2023

@narinder9 that means the sources loaded from gutenberg-block are not needed if using the new version? Could you then take care that these ressources are only loaded if the deprecated block is actually being used?

@narinder9
Copy link
Owner

Yes, we have already added checks and loaded sources based on conditions. We will release improvements update in upcoming week.
If you have any good solutions, please share with us we will defiantly follow and implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants