Add option for Tooltip component to be controlled with isOpen prop #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akdetrick
reviewed
Jun 22, 2023
| }) => { | ||
| const [isOpen, setIsOpen] = useState(false); | ||
| const isControlled = isOpen === true || isOpen === false; |
There was a problem hiding this comment.
Suggested change
| const isControlled = isOpen === true || isOpen === false; | |
| const isControlled = isOpen !== undefined; |
There was a problem hiding this comment.
Your expression is more type safe - disregard unless you like the simple one better (checks for presence of the prop rather than value)
akdetrick
approved these changes
Jun 22, 2023
|
🎉 This PR is included in version 2.46.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the
Tooltipcomponent to be a controlled component which is needed for https://github.com/narmi/banking/issues/33260.A developer can pass an optional
isOpenproperty to control if theTooltipis open or not.