Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility for all versions above PHP 5.3.3 #1

Merged
merged 13 commits into from Mar 31, 2017

Conversation

delboy1978uk
Copy link
Contributor

Hi there, I have updated your lib to be fully compatible with any version of PHP above v5.3.3. :-)
Please see here https://travis-ci.org/delboy1978uk/redis-cache

@coveralls
Copy link

coveralls commented Mar 30, 2017

Coverage Status

Coverage decreased (-3.03%) to 96.97% when pulling c29fdd9 on delboy1978uk:master into ddc77b2 on naroga:master.

@delboy1978uk
Copy link
Contributor Author

coverage decreased, huh? *checks

@delboy1978uk
Copy link
Contributor Author

the last line with only a } not covered? That's unfair lol! :'-(

@coveralls
Copy link

coveralls commented Mar 30, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling ee8a821 on delboy1978uk:master into ddc77b2 on naroga:master.

@delboy1978uk
Copy link
Contributor Author

Coverage back to 100% :-)

@delboy1978uk
Copy link
Contributor Author

Hola amigo!
I really need this pull request! I would much rather contribute to your project than hard fork and create my own composer package, but I'm pressed for time! I hope you get this soon!
Thanks
Derek

@naroga
Copy link
Owner

naroga commented Mar 31, 2017

Hi, @delboy1978uk. I'm reviewing your PR right now. Thank you for the contribution. Just give me a few minutes to check it out, ok? :

@naroga
Copy link
Owner

naroga commented Mar 31, 2017

LGTM. Merging to master and releasing it under a new minor, as it's 100% backwards compatible.

@naroga naroga merged commit dd80ce1 into naroga:master Mar 31, 2017
@naroga
Copy link
Owner

naroga commented Mar 31, 2017

@delboy1978uk Tagged under 1.1. composer update should suffice, if you are using semver constraints.

@delboy1978uk
Copy link
Contributor Author

thanks amigo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants