timeout and shutdown

[ssrlive]

No description provided.

[SajjadPourali]

Checking the timeout on pool_read functions is sufficient, as the timeout registers their context.

[ssrlive]

emm, i have removed the code. please review the rest modifications.

[ssrlive]

Not fixed yet.

[SajjadPourali]

Not fixed yet.

I see. Ignoring poll_shutdown causes other issues. Let me explore other options to fix it.

[SajjadPourali]

@ssrlive please check the log. I just fixed this issue; however, there is a minor race condition when both parties try to close sockets simultaneously.

[SajjadPourali]

@ssrlive could you please check the latest changes and verify if they work as expected?

[ssrlive]

Looks fine.

I think the bug is fixed.

[ssrlive]

please publish a new version.

[SajjadPourali]

please publish a new version.

Waiting for #24
@xmh0511

[SajjadPourali]

05988a3

[ssrlive]

ipstack/src/stream/tcp.rs

Lines 222 to 233 in 6b23ebf

	if matches!(
	Pin::new(&mut self.tcb.timeout).poll(cx),
	std::task::Poll::Ready(_)
	) {
	#[cfg(feature = "log")]
	trace!("timeout reached for {:?}", self.dst_addr);
	let flags = tcp_flags::RST | tcp_flags::ACK;
	self.packet_sender
	.send(self.create_rev_packet(flags, TTL, None, Vec::new())?)
	.map_err(|_| ErrorKind::UnexpectedEof)?;
	return std::task::Poll::Ready(Err(Error::from(ErrorKind::TimedOut)));
	}

between L231 and L232, should we add this?

                self.tcb.change_state(TcpState::Closed);
                self.shutdown.ready();

[SajjadPourali]

ipstack/src/stream/tcp.rs

Lines 222 to 233 in 6b23ebf

	if matches!(
	Pin::new(&mut self.tcb.timeout).poll(cx),
	std::task::Poll::Ready(_)
	) {
	#[cfg(feature = "log")]
	trace!("timeout reached for {:?}", self.dst_addr);
	let flags = tcp_flags::RST | tcp_flags::ACK;
	self.packet_sender
	.send(self.create_rev_packet(flags, TTL, None, Vec::new())?)
	.map_err(|_| ErrorKind::UnexpectedEof)?;
	return std::task::Poll::Ready(Err(Error::from(ErrorKind::TimedOut)));
	}

between L231 and L232, should we add this?

                self.tcb.change_state(TcpState::Closed);
                self.shutdown.ready();

Good catch! The AsyncWrite should also be closed when AsyncRead is closed.

[SajjadPourali]

@ssrlive : Could you also please check if rpref works after this fix?

[ssrlive]

you can install rperf with this command

cargo install --git https://github.com/ssrlive/rperf.git --branch nat

UDP testing passed,
TCP forward mode passed,
but TCP reverse-NAT mode failed.

I think it's not ipstack issues.

And all tests with iperf3 passed.