Skip to content
This repository has been archived by the owner on Mar 1, 2023. It is now read-only.

Fixes for LegacyTagsManager and SkeletonGenerator #61

Merged
merged 2 commits into from
Sep 3, 2018

Conversation

prisis
Copy link
Member

@prisis prisis commented Sep 2, 2018

fixes don't filter packages that have empty intersection with legacy tags
fixes lock writing in skeleton installer

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets -
License MIT
Doc PR -

…tags

fixes lock writing in skeleton installer
@prisis prisis changed the title fixes don't filter packages that have empty intersection with legacy … Fixes for LegacyTagsManager and SkeletonGenerator Sep 2, 2018
@codecov
Copy link

codecov bot commented Sep 2, 2018

Codecov Report

Merging #61 into master will increase coverage by 0.84%.
The diff coverage is 86.09%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #61      +/-   ##
===========================================
+ Coverage     55.26%   56.1%   +0.84%     
- Complexity      620     631      +11     
===========================================
  Files            39      39              
  Lines          1634    1663      +29     
===========================================
+ Hits            903     933      +30     
+ Misses          731     730       -1
Impacted Files Coverage Δ Complexity Δ
src/Automatic/Prefetcher/Prefetcher.php 0% <ø> (ø) 38 <0> (ø) ⬇️
src/Automatic/AbstractConfigurator.php 100% <100%> (ø) 13 <1> (ø) ⬇️
...tomatic/Prefetcher/TruncatedComposerRepository.php 72.72% <100%> (ø) 4 <1> (ø) ⬇️
src/Automatic/Installer/AbstractInstaller.php 100% <100%> (ø) 14 <1> (ø) ⬇️
src/Automatic/ClassFinder.php 98.23% <100%> (ø) 45 <6> (ø) ⬇️
src/Common/Package.php 100% <100%> (ø) 45 <25> (ø) ⬇️
src/Automatic/QuestionFactory.php 100% <100%> (ø) 7 <0> (ø) ⬇️
src/Automatic/ScriptExecutor.php 100% <100%> (ø) 12 <1> (ø) ⬇️
src/Automatic/LegacyTagsManager.php 100% <100%> (ø) 25 <0> (+10) ⬆️
src/Common/Installer/Installer.php 100% <100%> (ø) 8 <0> (ø) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc29d33...cc18984. Read the comment docs.

@prisis prisis merged commit 5be12ed into master Sep 3, 2018
@prisis prisis deleted the fix/tags-manger-and-skeleton branch September 3, 2018 06:55
@prisis prisis added this to the v0.4.1 milestone Sep 3, 2018
@prisis prisis added the Fixed Changelog Fixed label Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Fixed Changelog Fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant