Skip to content
This repository has been archived by the owner on Mar 1, 2023. It is now read-only.

Refactor Install, Update and Uninstall Events in Automatic #74

Merged
merged 2 commits into from
Sep 27, 2018

Conversation

prisis
Copy link
Member

@prisis prisis commented Sep 17, 2018

Q A
Bug fix? yes
New feature? no
BC breaks? yes
Deprecations? no
Related tickets fixes #80, fixes #82, fixes #81
License MIT
Doc PR -

@prisis prisis added Changed Changelog Changed Fixed Changelog Fixed Type: Bug labels Sep 17, 2018
@prisis prisis added this to the v0.8.0 milestone Sep 17, 2018
@codecov
Copy link

codecov bot commented Sep 24, 2018

Codecov Report

Merging #74 into master will increase coverage by 5.99%.
The diff coverage is 73.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #74      +/-   ##
============================================
+ Coverage     62.97%   68.96%   +5.99%     
- Complexity      770      808      +38     
============================================
  Files            51       53       +2     
  Lines          2066     2188     +122     
============================================
+ Hits           1301     1509     +208     
+ Misses          765      679      -86
Impacted Files Coverage Δ Complexity Δ
src/Automatic/AbstractConfigurator.php 100% <ø> (ø) 13 <0> (ø) ⬇️
src/Automatic/PackageConfigurator.php 100% <ø> (ø) 1 <0> (ø) ⬇️
src/Automatic/Prefetcher/Prefetcher.php 9.3% <0%> (+9.3%) 38 <14> (ø) ⬇️
src/Automatic/Container.php 100% <100%> (+32.94%) 6 <0> (ø) ⬇️
src/Automatic/Operation/Install.php 100% <100%> (ø) 32 <32> (?)
src/Automatic/Automatic.php 45.63% <41.91%> (+12.02%) 130 <26> (-2) ⬇️
src/Automatic/Operation/AbstractOperation.php 88.88% <88.88%> (ø) 14 <14> (?)
src/Automatic/Operation/Uninstall.php 90.9% <90.9%> (ø) 7 <7> (?)
src/Security/SecurityPlugin.php 90.4% <95.34%> (+0.92%) 41 <10> (+10) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2242fba...81cca87. Read the comment docs.

@prisis prisis changed the title working on new uninstaller for automatic Added new Uninstall Events to Automatic Sep 27, 2018
@prisis prisis changed the title Added new Uninstall Events to Automatic Refactor Install, Update and Uninstall Events in Automatic Sep 27, 2018
@prisis prisis merged commit 730a579 into master Sep 27, 2018
@prisis prisis deleted the fix/uninstall branch September 27, 2018 09:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Changed Changelog Changed Fixed Changelog Fixed Type: Bug
Projects
None yet
1 participant