Skip to content
This repository has been archived by the owner on Mar 1, 2023. It is now read-only.

added reset call if configurator was called in onPostAutoloadDump #85

Merged
merged 3 commits into from
Sep 29, 2018

Conversation

prisis
Copy link
Member

@prisis prisis commented Sep 28, 2018

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets -
License MIT
Doc PR -

@prisis prisis added the Fixed Changelog Fixed label Sep 28, 2018
@prisis prisis added this to the v0.8.2 milestone Sep 28, 2018
@prisis prisis changed the title added fix for a second load of the configurators in composer create-p… fixed second load of the configurators in composer create-p… Sep 28, 2018
@prisis prisis changed the title fixed second load of the configurators in composer create-p… fixed second load of the configurators Sep 28, 2018
@prisis prisis changed the title fixed second load of the configurators added reset call if configurator was called in onPostAutoloadDump Sep 28, 2018
@codecov
Copy link

codecov bot commented Sep 28, 2018

Codecov Report

Merging #85 into master will increase coverage by 0.65%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #85      +/-   ##
============================================
+ Coverage     69.66%   70.31%   +0.65%     
- Complexity      793      794       +1     
============================================
  Files            53       53              
  Lines          2126     2129       +3     
============================================
+ Hits           1481     1497      +16     
+ Misses          645      632      -13
Impacted Files Coverage Δ Complexity Δ
src/Automatic/PackageConfigurator.php 100% <ø> (ø) 1 <0> (ø) ⬇️
src/Automatic/Container.php 100% <100%> (ø) 6 <0> (ø) ⬇️
src/Automatic/Operation/AbstractOperation.php 88.88% <100%> (ø) 14 <0> (ø) ⬇️
src/Automatic/Automatic.php 58.65% <100%> (+4.01%) 132 <8> (+1) ⬆️
src/Automatic/ScriptExecutor.php 100% <100%> (ø) 12 <3> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f61d4b1...f82c00b. Read the comment docs.

@prisis prisis merged commit 25f231c into master Sep 29, 2018
@prisis prisis deleted the check-if-configurators-loaded branch September 29, 2018 09:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Fixed Changelog Fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant