Skip to content
This repository has been archived by the owner on Mar 1, 2023. It is now read-only.

adding psr-15 #399

Merged
merged 7 commits into from Oct 13, 2016
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions composer.json
Expand Up @@ -42,6 +42,7 @@
"egulias/email-validator" : "^2.1",
"filp/whoops" : "^2.0",
"http-interop/http-factory" : "dev-master",
"http-interop/http-middleware" : "^0.2",
"league/flysystem" : "^1.0.27",
"monolog/monolog" : "^1.17",
"narrowspark/arr" : "^2.1",
Expand Down
25 changes: 0 additions & 25 deletions src/Viserio/Contracts/Middleware/ClientMiddleware.php

This file was deleted.

18 changes: 0 additions & 18 deletions src/Viserio/Contracts/Middleware/Delegate.php

This file was deleted.

7 changes: 0 additions & 7 deletions src/Viserio/Contracts/Middleware/Middleware.php

This file was deleted.

25 changes: 0 additions & 25 deletions src/Viserio/Contracts/Middleware/ServerMiddleware.php

This file was deleted.

6 changes: 3 additions & 3 deletions src/Viserio/Contracts/Routing/Route.php
Expand Up @@ -2,9 +2,9 @@
declare(strict_types=1);
namespace Viserio\Contracts\Routing;

use Interop\Http\Middleware\MiddlewareInterface;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Viserio\Contracts\Middleware\Middleware as MiddlewareContract;

interface Route
{
Expand Down Expand Up @@ -60,14 +60,14 @@ public function where($name, string $expression = null): Route;
*
* @return $this
*/
public function withMiddleware(MiddlewareContract $middleware): Route;
public function withMiddleware(MiddlewareInterface $middleware): Route;

/**
* Remove a middleware from route.
*
* @return $this
*/
public function withoutMiddleware(MiddlewareContract $middleware): Route;
public function withoutMiddleware(MiddlewareInterface $middleware): Route;

/**
* Get all middleware, including the ones from the controller.
Expand Down
6 changes: 3 additions & 3 deletions src/Viserio/Contracts/Routing/Router.php
Expand Up @@ -2,9 +2,9 @@
declare(strict_types=1);
namespace Viserio\Contracts\Routing;

use Interop\Http\Middleware\MiddlewareInterface;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Viserio\Contracts\Middleware\Middleware as MiddlewareContract;

interface Router
{
Expand Down Expand Up @@ -170,14 +170,14 @@ public function getParameters(): array;
*
* @return $this
*/
public function withMiddleware(MiddlewareContract $middleware): Router;
public function withMiddleware(MiddlewareInterface $middleware): Router;

/**
* Remove a middleware from all routes.
*
* @return $this
*/
public function withoutMiddleware(MiddlewareContract $middleware): Router;
public function withoutMiddleware(MiddlewareInterface $middleware): Router;

/**
* Get all with and without middlewares.
Expand Down
13 changes: 5 additions & 8 deletions src/Viserio/Cookie/Middleware/AddQueuedCookiesToResponse.php
Expand Up @@ -2,13 +2,12 @@
declare(strict_types=1);
namespace Viserio\Cookie\Middleware;

use Psr\Http\Message\ResponseInterface;
use Interop\Http\Middleware\DelegateInterface;
use Interop\Http\Middleware\MiddlewareInterface;
use Psr\Http\Message\ServerRequestInterface;
use Viserio\Contracts\Cookie\QueueingFactory as CookieJar;
use Viserio\Contracts\Middleware\Delegate as DelegateContract;
use Viserio\Contracts\Middleware\Middleware as MiddlewareContract;

class AddQueuedCookiesToResponse implements MiddlewareContract
class AddQueuedCookiesToResponse implements MiddlewareInterface
{
/**
* The cookie jar instance.
Expand All @@ -30,10 +29,8 @@ public function __construct(CookieJar $cookies)
/**
* {@inheritdoc}
*/
public function handle(
ServerRequestInterface $request,
DelegateContract $frame
): ResponseInterface {
public function process(ServerRequestInterface $request, DelegateInterface $frame)
{
$response = $frame->next($request);

foreach ($this->cookies->getQueuedCookies() as $cookie) {
Expand Down
12 changes: 5 additions & 7 deletions src/Viserio/Cookie/Middleware/EncryptedCookie.php
Expand Up @@ -4,15 +4,15 @@

use Defuse\Crypto\Exception\EnvironmentIsBrokenException;
use Defuse\Crypto\Exception\WrongKeyOrModifiedCiphertextException;
use Interop\Http\Middleware\DelegateInterface;
use Interop\Http\Middleware\MiddlewareInterface;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Viserio\Contracts\Cookie\Cookie as CookieContract;
use Viserio\Contracts\Encryption\Encrypter as EncrypterContract;
use Viserio\Contracts\Middleware\Delegate as DelegateContract;
use Viserio\Contracts\Middleware\Middleware as MiddlewareContract;
use Viserio\Cookie\Cookie;

class EncryptCookies implements MiddlewareContract
class EncryptCookies implements MiddlewareInterface
{
/**
* The encrypter instance.
Expand Down Expand Up @@ -41,10 +41,8 @@ public function __construct(EncrypterContract $encrypter)
/**
* {@inheritdoc}
*/
public function handle(
ServerRequestInterface $request,
DelegateContract $frame
): ResponseInterface {
public function process(ServerRequestInterface $request, DelegateInterface $frame)
{
return $this->encrypt($frame->next($this->decrypt($request)));
}

Expand Down
Expand Up @@ -9,7 +9,9 @@

class FilesystemHelperTraitTest extends \PHPUnit_Framework_TestCase
{
use FilesystemHelperTrait;
use FilesystemHelperTrait {
isWritable as filesystemIsWritable;
}
use NormalizePathAndDirectorySeparatorTrait;

/**
Expand Down Expand Up @@ -47,11 +49,11 @@ public function testIsWritable()
{
$file = vfsStream::newFile('foo.txt', 0444)->withContent('foo')->at($this->root);

$this->assertFalse($this->isWritable($file->url()));
$this->assertFalse($this->filesystemIsWritable($file->url()));

$file->chmod(0777);

$this->assertTrue($this->isWritable($file->url()));
$this->assertTrue($this->filesystemIsWritable($file->url()));
}

public function testIsFile()
Expand Down
12 changes: 6 additions & 6 deletions src/Viserio/Middleware/Dispatcher.php
Expand Up @@ -2,13 +2,13 @@
declare(strict_types=1);
namespace Viserio\Middleware;

use Interop\Http\Middleware\DelegateInterface;
use Interop\Http\Middleware\MiddlewareInterface;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;
use SplDoublyLinkedList;
use SplStack;
use Viserio\Contracts\Container\Traits\ContainerAwareTrait;
use Viserio\Contracts\Middleware\Delegate as DelegateContract;
use Viserio\Contracts\Middleware\Middleware as MiddlewareContract;
use Viserio\Contracts\Middleware\Stack as StackContract;

class Dispatcher implements StackContract
Expand Down Expand Up @@ -47,7 +47,7 @@ public function __construct(ResponseInterface $response)
/**
* {@inheritdoc}
*/
public function withMiddleware(MiddlewareContract $middleware): StackContract
public function withMiddleware(MiddlewareInterface $middleware): StackContract
{
$this->stack->push($this->isContainerAware($middleware));

Expand All @@ -57,7 +57,7 @@ public function withMiddleware(MiddlewareContract $middleware): StackContract
/**
* {@inheritdoc}
*/
public function withoutMiddleware(MiddlewareContract $middleware): StackContract
public function withoutMiddleware(MiddlewareInterface $middleware): StackContract
{
foreach ($this->stack as $key => $stackMiddleware) {
if (get_class($this->stack[$key]) === get_class($middleware)) {
Expand All @@ -73,7 +73,7 @@ public function withoutMiddleware(MiddlewareContract $middleware): StackContract
*/
public function process(RequestInterface $request): ResponseInterface
{
return (new class($this->stack, $this->response) implements DelegateContract {
return (new class($this->stack, $this->response) implements DelegateInterface {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Class name ($this->stack, is not in camel caps format
  • Expected 1 space before response; 2 found
  • Expected 0 spaces between response and comma; 1 found
  • Opening brace of a class must be on the line after the definition

private $middlewares;

private $response;
Expand Down Expand Up @@ -113,7 +113,7 @@ private function nextFrame()
*
* @return \Viserio\Contracts\Middleware\Middleware
*/
private function isContainerAware($middleware): MiddlewareContract
private function isContainerAware($middleware): MiddlewareInterface
{
if (method_exists($middleware, 'setContainer')) {
$middleware->setContainer($this->getContainer());
Expand Down
Expand Up @@ -2,19 +2,19 @@
declare(strict_types=1);
namespace Viserio\Middleware\Tests\Fixture;

use Interop\Http\Middleware\DelegateInterface;
use Interop\Http\Middleware\ServerMiddlewareInterface;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Viserio\Contracts\Container\Traits\ContainerAwareTrait;
use Viserio\Contracts\Middleware\Delegate as DelegateContract;
use Viserio\Contracts\Middleware\ServerMiddleware as ServerMiddlewareContract;

class FakeContainerMiddleware implements ServerMiddlewareContract
class FakeContainerMiddleware implements ServerMiddlewareInterface
{
use ContainerAwareTrait;

public function process(
ServerRequestInterface $request,
DelegateContract $frame
DelegateInterface $frame
): ResponseInterface {
$response = $frame->next($request);
$response = $response->withAddedHeader('X-Foo', $this->getcontainer()->get('doo'));
Expand Down
13 changes: 5 additions & 8 deletions src/Viserio/Middleware/Tests/Fixture/FakeMiddleware.php
Expand Up @@ -2,17 +2,14 @@
declare(strict_types=1);
namespace Viserio\Middleware\Tests\Fixture;

use Psr\Http\Message\ResponseInterface;
use Interop\Http\Middleware\DelegateInterface;
use Interop\Http\Middleware\ServerMiddlewareInterface;
use Psr\Http\Message\ServerRequestInterface;
use Viserio\Contracts\Middleware\Delegate as DelegateContract;
use Viserio\Contracts\Middleware\ServerMiddleware as ServerMiddlewareContract;

class FakeMiddleware implements ServerMiddlewareContract
class FakeMiddleware implements ServerMiddlewareInterface
{
public function process(
ServerRequestInterface $request,
DelegateContract $frame
): ResponseInterface {
public function process(ServerRequestInterface $request, DelegateInterface $frame)
{
$response = $frame->next($request);

$response = $response->withAddedHeader('X-Foo', 'modified');
Expand Down
8 changes: 4 additions & 4 deletions src/Viserio/Middleware/Tests/Fixture/FakeMiddleware2.php
Expand Up @@ -2,16 +2,16 @@
declare(strict_types=1);
namespace Viserio\Middleware\Tests\Fixture;

use Interop\Http\Middleware\DelegateInterface;
use Interop\Http\Middleware\ServerMiddlewareInterface;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Viserio\Contracts\Middleware\Delegate as DelegateContract;
use Viserio\Contracts\Middleware\ServerMiddleware as ServerMiddlewareContract;

class FakeMiddleware2 implements ServerMiddlewareContract
class FakeMiddleware2 implements ServerMiddlewareInterface
{
public function process(
ServerRequestInterface $request,
DelegateContract $frame
DelegateInterface $frame
): ResponseInterface {
$response = $frame->next($request);

Expand Down
6 changes: 3 additions & 3 deletions src/Viserio/Routing/AbstractController.php
Expand Up @@ -2,7 +2,7 @@
declare(strict_types=1);
namespace Viserio\Routing;

use Viserio\Contracts\Middleware\Middleware as MiddlewareContract;
use Interop\Http\Middleware\MiddlewareInterface;

abstract class AbstractController
{
Expand All @@ -21,7 +21,7 @@ abstract class AbstractController
*
* @return $this
*/
public function withMiddleware(MiddlewareContract $middleware)
public function withMiddleware(MiddlewareInterface $middleware)
{
$this->middleware['with'][] = $middleware;

Expand All @@ -33,7 +33,7 @@ public function withMiddleware(MiddlewareContract $middleware)
*
* @return $this
*/
public function withoutMiddleware(MiddlewareContract $middleware)
public function withoutMiddleware(MiddlewareInterface $middleware)
{
$this->middleware['without'][] = $middleware;

Expand Down