fix(slice): calculate classified name once for namespaced slice

nartc · Jul 13, 2022 · 950ec1d · 950ec1d
1 parent 68a99c2
commit 950ec1d
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 6 deletions.
diff --git a/packages/ngrx-slice/.release-it.json b/packages/ngrx-slice/.release-it.json
@@ -28,8 +28,8 @@
       }
     },
     "@release-it/bumper": {
-      "in": "packages/ngrx-slice/package.json",
-      "out": ["packages/ngrx-slice/package.json", "dist/packages/ngrx-slice/package.json"]
+      "in": "packages/ngrx-slice/version.json",
+      "out": "dist/packages/ngrx-slice/package.json"
     }
   },
   "git": {

diff --git a/packages/ngrx-slice/package.json b/packages/ngrx-slice/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngrx-slice",
-  "version": "6.2.1",
+  "version": "0.0.0",
   "license": "MIT",
   "description": "createSlice plugin for NgRX",
   "keywords": [

diff --git a/packages/ngrx-slice/src/lib/create-slice.ts b/packages/ngrx-slice/src/lib/create-slice.ts
@@ -105,12 +105,14 @@ export function createNamespacedSlice<
     sliceActionNameGetter,
   });
 
+  const classifiedName = classify(name);
+
   return {
-    [`${classify(name)}Feature`]: {
+    [`${classifiedName}Feature`]: {
       name: sliceName,
       reducer,
     },
-    [`${classify(name)}Actions`]: actions,
-    [`${classify(name)}Selectors`]: selectors,
+    [`${classifiedName}Actions`]: actions,
+    [`${classifiedName}Selectors`]: selectors,
   } as NamespacedSlice<SliceState, SliceName, CaseReducers>;
 }
diff --git a/packages/ngrx-slice/version.json b/packages/ngrx-slice/version.json
@@ -0,0 +1,3 @@
+{
+  "version": "6.2.1"
+}