Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to angular v6 #5

Closed
wants to merge 3 commits into from
Closed

update to angular v6 #5

wants to merge 3 commits into from

Conversation

andrasczeh
Copy link

I've upgraded to angular 6, and applied a workaround in polyfills.ts. Nice project by the way!

@narve
Copy link
Owner

narve commented Aug 17, 2018

Hi @andrasczeh thanks a lot for this contribution, and sorry for the late reply!

I tried to merge this PR but it doesn't seem to work in production builds with the other commits in my project (possibly bpmn-js lib updates from #4). Could you take a look at https://github.com/narve/angular-bpmn/tree/andrasczeh-master and see if you spot the problem?

@andrasczeh
Copy link
Author

Hi, sorry for the late reply. I looked into it and seems to be an issue with the angular buildoptimizer. angular/angular-cli#10655
A workaround would be to disable it, but I will try to find a real solution within a few days.

@besteban1989
Copy link

besteban1989 commented Oct 5, 2018

Hi guys, I've been trying to make this work for an angular 6 version but no success.
In dev time works great, but when I build it for production then I get this error:

main.72aee93….js:1 ERROR TypeError: this._createContainer is not a function at ap.on (main.72aee93….js:1) at new ap (main.72aee93….js:1) at t.ngOnInit (main.72aee93….js:1) at main.72aee93….js:1 at main.72aee93….js:1 at Zi (main.72aee93….js:1) at Oo (main.72aee93….js:1) at Object.updateDirectives (main.72aee93….js:1) at Object.updateDirectives (main.72aee93….js:1) at Ki (main.72aee93….js:1)

And as @andrasczeh mention, after removing the angular optimizer it work.

@narve
Copy link
Owner

narve commented Dec 3, 2018

Master is now upgraded to Angular 7, with the same bug (createContainer) in production mode. Production mode is not really a requirement so I'm just ignoring it for now.

@narve narve closed this Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants