Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"01" returns "เอ็ดบาทถ้วน #14

Closed
narze opened this issue Nov 8, 2021 · 5 comments · Fixed by #15 or #17
Closed

"01" returns "เอ็ดบาทถ้วน #14

narze opened this issue Nov 8, 2021 · 5 comments · Fixed by #15 or #17

Comments

@narze
Copy link
Owner

narze commented Nov 8, 2021

Should be "หนึ่งบาทถ้วน"
image
@l2D l2D mentioned this issue Jan 21, 2022
Merged
1 task
@l2D
Copy link
Contributor

l2D commented Jan 21, 2022

@narze I added new PR to handle these cases.

@narze
Copy link
Owner Author

narze commented Jan 27, 2022

Sorry I didn't have time to check issues, will review shortly

@narze narze closed this as completed in #15 Jan 27, 2022
@rootEnginear
Copy link
Contributor

This bug is still present in version 0.7.0. The current test covers "-01" but "01", which might be why you overlooked this. I'll add more tests to this now that I've found more bugs.

@rootEnginear rootEnginear mentioned this issue Mar 27, 2022
Merged
@l2D
Copy link
Contributor

l2D commented Mar 27, 2022

This bug is still present in version 0.7.0. The current test covers "-01" but "01", which might be why you overlooked this. I'll add more tests to this now that I've found more bugs.

I totally missed it! 😱 Thank you for the PR, @rootEnginear .

@narze
Copy link
Owner Author

narze commented Mar 27, 2022

😱 😱 😱

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@narze @rootEnginear @l2D