-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binary conversions for CALET #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run black to fix the CI pipeline failures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember to run black...
The lint checks are still failing. #21 will automate the code formatting for you once it's merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like a PR that adds a parser for one notice type.
For future reference, do you want an individual PR for each notice type? |
"trigger_type": "rate", | ||
"rate_energy_range": [energy_range_data[1], energy_range_data[0]], | ||
"rate_snr": bin_arr[9] * 1e-2, | ||
"rate_duration": bin_arr[11] * 1e-2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation calls this field bkg_dur1
. Field 10 is fore_dur
. Which one corresponds to rate_duration
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason I chose bkg_dur1 is that the documentation defines it as "the amount of time (units centi-sec) used to determine the background countrate when used for the lc_significance" and the descriptions for rate_duration is "Interval over rate signal to noise ratio calculation". Although thinking about it again I believe bkg_dur1 is being used to calculate the noise, so should I switch to fore_dur?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jracusin, @Vidushi-GitHub, would you please check this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of it corresponds to rate_duration, as that's defined as signal to noise ratio. CALET has defined "bkg_dur1" as interval before the trigger, fore_dur as triggering interval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation defines lc_signif as "signal-to-noise ratio (in units of centi-sigma) during the foreground interval". Are foreground interval and triggerring interval different?
@athish-thiru, would you please rebase from main again? |
ca8b1b9
to
39612ca
Compare
@lpsinger I believe I have rebased to the new main now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix pipeline failures.
I also want to note that the url(http://cgbm.calet.jp/cgbm_trigger/flight/1399729386/index.html) doesn't link to anything. I've added for completeness since the fields do contain data and the url is present in the text notices as well. |
@jracusin, @Vidushi-GitHub, would you please track down what the correct URLs are for the CALET notices? |
Explicit int conversion removed MAXI_UNKNOWN conversion Removed GECAM_FLT and GECAM_GND conversion Added documentation and changed function name reformatted file deleted files
I didn't add asserts for these since:
|
Binary conversions for GECAM mission. Note