Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newly created Circular does not immediately appear in index after form submission #1699

Closed
lpsinger opened this issue Nov 22, 2023 · 2 comments · Fixed by #1705
Closed

Newly created Circular does not immediately appear in index after form submission #1699

lpsinger opened this issue Nov 22, 2023 · 2 comments · Fixed by #1705
Assignees
@lpsinger
Labels
bug Something isn't working

Comments

@lpsinger
Copy link
Member

The Circular is submitted, but you have to refresh the page to see it.

This is because the useActionData() call in the index route is not returning the result from the action function from the layout route that was executed.

This probably broke either due to recent route module refactoring or a Remix version update.
@lpsinger lpsinger added the bug Something isn't working label Nov 22, 2023
@lpsinger lpsinger self-assigned this Nov 22, 2023
@lpsinger
Copy link
Member Author

git bisect shows that this was broken by #1664.

@lpsinger
Copy link
Member Author

Aha! This must have been broken by remix-run/react-router#11023.

@lpsinger lpsinger mentioned this issue Nov 26, 2023
Merged
lpsinger added a commit to lpsinger/gcn.nasa.gov that referenced this issue Nov 27, 2023
@lpsinger
Show just-created Circular after new submission
a892b8f 
Fixes nasa-gcn#1699.
@lpsinger lpsinger mentioned this issue Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lpsinger lpsinger

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show just-created Circular after new submission lpsinger/gcn.nasa.gov
1 participant
@lpsinger