Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo Timeline in React #108

Closed
minniewong opened this issue Jan 5, 2017 · 5 comments
Closed

Redo Timeline in React #108

minniewong opened this issue Jan 5, 2017 · 5 comments
Labels

Comments

@minniewong
Copy link
Contributor

No description provided.

@polluxll
Copy link

polluxll commented May 8, 2017

I want to add my own data on worldview,but the time step is hourly.dose the timeline support the hourly data?

@Benjaki2
Copy link
Collaborator

Benjaki2 commented May 8, 2017

As the code sits now, you can't show sub-daily timescales on the timeline. I don't think that it would take too much tweaking of the timeline module to accommodate for another zoom level. However, the current implementation of the timeline is not the most scalable and that is the purpose of this issue. Upon completion of this issue, the idea is that you will be able to insert any scale to the props of the component and the timeline will respond dynamically. Let me know if you would be interested in collaborating with us on this effort or if you would like to be pointed in the right direction so that you can do your own 'quick-fix'.

@polluxll
Copy link

polluxll commented May 9, 2017

thanks, I will have a try。

@ZachTRice
Copy link
Contributor

Currently the timeline has an issue in FF with the svg width being calculated. When you drag the window, the timeline breaks to the next line briefly. This is not a huge issue but something to note when we convert to react.

@minniewong
Copy link
Contributor Author

Won't redo timeline in React but will work on timeline in #555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants