Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back the Iceberg natural event icon #3428

Closed
edplato opened this issue Mar 25, 2021 · 1 comment
Closed

Bring back the Iceberg natural event icon #3428

edplato opened this issue Mar 25, 2021 · 1 comment
Assignees
Milestone

Comments

@edplato
Copy link
Collaborator

edplato commented Mar 25, 2021

Describe the bug
Somewhere along the way, we lost implementing our Iceberg natural event icon for Icebergs and now use our Sea and Lake Ice icon. I like both, but the Iceberg one looks more intuitive to me. I think some logic needs to be added where the event marker types are parsed due to EONET Iceberg events categorized as:

categories: [
  {
    id: "seaLakeIce",
    title: "Sea and Lake Ice"
  }
],

I'm sure there is legitimate Sea and Lake Ice that deserve the Sea and Lake Ice icon, so just an idea for parsing is if "Iceberg" isn't in the event title then use the Sea and Lake Ice icon.

@jasontk19
Copy link
Collaborator

Since we represent categories by their icon in the sidebar, I don't think we want to use two different icons for one category based on whether it's an iceberg or sea/lake ice. That said, the current sea and lake ice icon looks a lot like the water color icon anyway and, most of these events are icebergs, and the iceberg icon looks cool. So, I think we're fine doing a one to one swap.

Screen Shot 2021-06-08 at 2 21 43 PM

jasontk19 added a commit that referenced this issue Jun 9, 2021
jasontk19 added a commit that referenced this issue Jun 11, 2021
jasontk19 added a commit that referenced this issue Jun 14, 2021
jasontk19 added a commit that referenced this issue Jun 17, 2021
jasontk19 added a commit that referenced this issue Jun 18, 2021
jasontk19 added a commit that referenced this issue Jun 21, 2021
@jasontk19 jasontk19 mentioned this issue Jun 23, 2021
5 tasks
jasontk19 added a commit that referenced this issue Jun 23, 2021
jasontk19 added a commit that referenced this issue Jul 6, 2021
jasontk19 added a commit that referenced this issue Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants