Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WV-2073: Animation Loading bar #3797

Merged
merged 2 commits into from Jan 25, 2022
Merged

WV-2073: Animation Loading bar #3797

merged 2 commits into from Jan 25, 2022

Conversation

jasontk19
Copy link
Collaborator

@jasontk19 jasontk19 commented Jan 14, 2022 •
edited

Description

  • Reduce initial buffer size to 10
  • Show loading bar when animation is pre-loading

To-Do

  • Change target branch to release-3.17.0 before merge

To Test

  • Try animations of varying length
  • Observe loading bar shows while tiles are pre-loading

@jasontk19 jasontk19 added this to the v3.17.0 milestone Jan 14, 2022
@jasontk19 jasontk19 self-assigned this Jan 14, 2022
@jasontk19 jasontk19 marked this pull request as ready for review January 20, 2022 16:22
minniewong
minniewong approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@minniewong minniewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jasontk19 jasontk19 changed the base branch from wv-2011 to release-3.17.0 January 24, 2022 19:55
@jasontk19
WV-2073
ecec769 
- Reduce initial buffer size to 10
- Show loading bar when animation is pre-loading
@jasontk19
WV-2073
e57d2e4 
- one bar to rule them all
- renaming file to loading indicator
@jasontk19 jasontk19 merged commit 7e35877 into release-3.17.0 Jan 25, 2022
@jasontk19 jasontk19 deleted the wv-2073 branch January 25, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minniewong minniewong minniewong approved these changes

@jwhurley1 jwhurley1 Awaiting requested review from jwhurley1

Assignees

@jasontk19 jasontk19

Labels
None yet
Projects
None yet
Milestone
v3.17.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jasontk19 @minniewong