Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to ice velocity and chlorophll #5029

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

minniewong
Copy link
Contributor

@minniewong minniewong commented Mar 5, 2024

Description

Fixes #WV-3067.

  1. git checkout wv-3067-ice-velocity-chlorophyll
  2. npm run build && npm start
  3. Open with these URL parameters Ice Velocity (Greenland)
  4. Check that layer description is correct and links work
  5. Open with these URL parameters Ice Velocity (Antarctica)
  6. Check that layer description is correct and links work
  7. Open with these URL parameters Chlorophyll a
  8. Check links in the About Chlorophyll a section to ensure they work

How To Test

[Provide whatever information a reviewer might need to know in order to verify that the changes made in this PR are working as expected. If there are special build steps that need to be taken in order to get these changes to run (building while on a separate branch, running npm ci, etc) include them here.]

  • For bugfixes: What steps need to be taken in the UI to verify the bug is fixed?
  • For enhancements and features: What is the expected functionality being added/modified? How can a reviewer verify this?
  1. Open with these URL parameters
  2. ...
  3. Verify expected result

PR Submission Checklist

This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have added necessary documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Any dependent changes have been merged and published in downstream modules (if applicable)

Merging

Please use the squash and merge commit method unless each commit in your branch is vital to the commit history of main.

@nasa-gibs/worldview

@Tomcariello
Copy link
Contributor

This looks good.

This is maybe out of scope, but in the Chlorophyll a (l2) layer description there is a link that leads to an error page
https://doi.org/10.5067/TERRA/MODIS/L2/OC/2018

@minniewong
Copy link
Contributor Author

This looks good.

This is maybe out of scope, but in the Chlorophyll a (l2) layer description there is a link that leads to an error page https://doi.org/10.5067/TERRA/MODIS/L2/OC/2018

Thanks @Tomcariello these will probably be updated very soon, but we're waiting on that DAAC for other updates

@minniewong minniewong merged commit bae3b0d into develop Mar 5, 2024
2 of 4 checks passed
@minniewong minniewong deleted the wv-3067-ice-velocity-chlorophyll branch March 5, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants