Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WV-3147 update collections when projection changes #5122

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

PatchesMaps
Copy link
Contributor

@PatchesMaps PatchesMaps commented Apr 17, 2024

Description

Currently, for MODIS_Aqua_NDSI_Snow_Cover on 2007-FEB-26 we have c6.1 for both the poles but have not received 6.1 for geographic yet. We only have 6.0 for geographic for that day.

Steps:

Load Worldview geographic for MODIS_Aqua_NDSI_Snow_Cover. Change the date to 2007- FEB-26. The badge shows " v6STD" which is correct for geographic (at the moment). Now switch to either of the poles. It still shows " v6 STD" which is incorrect b/c we have v6.1 for both poles.

Now open a new window, switch the projection to one of the poles, add MODIS_Aqua_NDSI_Snow_Cover. Change the date to 2007- FEB-26. The badge shows " v6.1 STD" which is correct for the poles. Now switch the projection to geographic. Geographic show "v6.1 STD" which is incorrect. We have not received v6.1 for geographic for that day yet.

It appears whichever projection is loaded first, caches the version for that product across all projections.

How To Test

  1. git checkout WV-3147-incorrect-badge-version
  2. npm run watch
  3. Go to this link (I'll try to keep this link updated)
  4. Geographic should show v6, Arctic/Antarctic should show v6.1

PR Submission Checklist

This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have added necessary documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Any dependent changes have been merged and published in downstream modules (if applicable)

Merging

Please use the squash and merge commit method unless each commit in your branch is vital to the commit history of main.

@nasa-gibs/worldview

@PatchesMaps PatchesMaps marked this pull request as ready for review April 18, 2024 15:37
@PatchesMaps PatchesMaps merged commit e8aa908 into develop Apr 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants