Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding files for control board v2.0.1+2+3 #396

Merged
merged 3 commits into from
Aug 19, 2023

Conversation

apollokit
Copy link
Collaborator

Also, updates to arduino shield, and updates to pcb assembly READMEs

@apollokit apollokit self-assigned this Jul 25, 2023
@apollokit apollokit mentioned this pull request Jul 25, 2023
64 tasks
@apollokit
Copy link
Collaborator Author

This replaces the older draft PR here: #198

@Achllle
Copy link
Collaborator

Achllle commented Jul 25, 2023

Might want to do a rebase, this seems to be re-introducing a bunch of files that were already deleted in the target branch

@apollokit
Copy link
Collaborator Author

Might want to do a rebase, this seems to be re-introducing a bunch of files that were already deleted in the target branch

Sure about that? Here's the diff:
image

Are you saying that the hierarchy of electrical/pcb/control_board and electrical/pcb/arduino_uno_shield is not what we want?

@Achllle
Copy link
Collaborator

Achllle commented Jul 25, 2023

Is it doable to correct that atrocious sheild typo? 🥲

@apollokit
Copy link
Collaborator Author

apollokit commented Jul 25, 2023

Is it doable to correct that atrocious sheild typo? 🥲

oh boy, i hadn't even noticed that. Has that just always been there? I suppose it's fixable...

EDIT: fixed it now

@Achllle
Copy link
Collaborator

Achllle commented Jul 27, 2023

@apollokit can you remove the old files? I think it's best if they're not part of v2.

@apollokit
Copy link
Collaborator Author

@apollokit can you remove the old files? I think it's best if they're not part of v2.

done

@apollokit apollokit requested a review from Achllle August 2, 2023 05:33
@apollokit apollokit merged commit 56d529b into nasa-jpl:v2 Aug 19, 2023
2 checks passed
@apollokit
Copy link
Collaborator Author

Merging this now to be done with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants