Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme to add BOM and part references for control board assembly #448

Merged
merged 14 commits into from
Apr 11, 2024

Conversation

apollokit
Copy link
Collaborator

Finally add the proper documentation for control board part references to the repo.

Also fixed a couple small todos in the readme file for the pcb - reviewed section numbering and linked to the schematics/layout files

@apollokit apollokit self-assigned this Feb 5, 2024
@apollokit apollokit marked this pull request as draft February 5, 2024 00:24
@apollokit apollokit changed the title [DRAFT] update readme to add BOM and part references for control board assembly Update readme to add BOM and part references for control board assembly Feb 5, 2024
Copy link
Collaborator

@ericjunkins ericjunkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BOM and instructions at a glance look good to me. I didn't look through all the line items and BOM stuff to make sure it all lines up with what is needed though. Do you feel confident about that?

@apollokit apollokit marked this pull request as ready for review March 6, 2024 06:33
@apollokit
Copy link
Collaborator Author

The BOM and instructions at a glance look good to me. I didn't look through all the line items and BOM stuff to make sure it all lines up with what is needed though. Do you feel confident about that?

I think there's a little iteration to do there, admittedly. The standoffs are the biggest thing. I figured it would be good to get these files in and versioned, at least, and follow up to make sure everything is as up to date as it should be. Maybe not the best process.

@Achllle
Copy link
Collaborator

Achllle commented Mar 7, 2024

This is a classic case of balancing speed of getting improvements in vs making sure that getting a half solution in doesn't just stay a half solution.

@apollokit it's up to you to decide if it will be best if we get this in now and you make a follow-up PR soon ™️ (<6 weeks) with improvements or you add in the final pieces in a shorter timeline (<2 weeks) and we merge it in and that's it.

@apollokit apollokit merged commit 79aec55 into nasa-jpl:master Apr 11, 2024
2 checks passed
@apollokit
Copy link
Collaborator Author

Went ahead and merged. I went through the line items again and I'm pretty confident things are mostly right. There could be some small mistakes in there, but nothing that should be a blocker.

More work to follow up on the TODOs here: #449

@apollokit apollokit deleted the pcb2_update_readme branch April 11, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants