Clarify instructions in README + update default gamepad velocity values #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gfosmire since you still haven't reviewed this, pulling you off and adding @apollokit |
|
Right off the bat, of course, this'll need to be updated to reflect the changes from #108 |
… into update_readme_configuring Resolve merge conflicts by simply moving changes to appropriate readme locations
|
@apollokit resolved the merge conflict, ready for review |
|
Sorry for the delay, will get to this this week |
apollokit
requested changes
Oct 16, 2020
Co-authored-by: Kit Kennedy <kitkennedy8@gmail.com>
Achllle
commented
Oct 16, 2020
|
Addressed your suggestions. Let me know if it makes more sense and feel free to make another suggestion |
|
Cool, looks good. |
|
FYI policy we've used in this repo is to let the assignee or PR opener do the merge. For this one it doesn't matter but it can cause trouble when there's dependent PRs and so on that the reviewer isn't always aware of |
|
Gotcha, noted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some extra clarifications + verbosity to the main README
The default velocities for the default drive motor configuration (31rpm) was also incorrect with the velocities for turbo being way too high.