Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing commands in the rover_bringup.md file #120

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Fixing commands in the rover_bringup.md file #120

merged 1 commit into from
Oct 16, 2020

Conversation

apollokit
Copy link
Collaborator

Commands hadn't been updated before

Achllle
Achllle approved these changes Oct 15, 2020
View reviewed changes
Copy link
Collaborator

@Achllle Achllle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice. I think LaunchOSR.sh probably shouldn't live in the home dir and instead the script should point to /usr/bin instead, but tbh this is also fine.

@apollokit
Copy link
Collaborator Author

On LaunchOSR.sh in the home dir....meh. Don't feel particularly strongly, but I'll just leave as is.

@apollokit apollokit merged commit 718c18d into nasa-jpl:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Achllle Achllle Achllle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@apollokit @Achllle