Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rover full stop the wheels when idle #123

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

apollokit
Copy link
Collaborator

Made the rover truly idle when it's supposed to be idle

Now we command the wheels to fully stop when a command hasn't been received for a little bit. This consumes less current, and avoids the chattering noise that was present when idle before.

… idle. Now also sending a full stop command after a little bit so that we can minimize idle power consumption
@apollokit
Copy link
Collaborator Author

Separated out from: #122

Copy link
Collaborator

@Achllle Achllle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the 'full stop' when idling, did you notice significant ramping behavior? The deceleration factor is pretty steep so I'm wondering if there's much of a difference. If not, might be better to keep the code simpler.

@Achllle
Copy link
Collaborator

Achllle commented Feb 14, 2021

@apollokit bump

@apollokit apollokit merged commit 885c4b1 into nasa-jpl:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants