INA260 support #175
INA260 support #175
Conversation
|
LGTM. I think you only changed one file? |
|
Huh, not sure why it didn't get through. I'll make sure the PR is complete after tonight's maintainer meeting. Need to figure out what's going on with my INA in the first place. |
| @@ -0,0 +1,21 @@ | |||
| import argparse | |||
| from ina260.controller import Controller | |||
There was a problem hiding this comment.
I'm confused about what file this import statement refers to....I see no ina260.py in this directory on the latest commit on this branch. Am I just missing it somehow?
Does test_ina260.py need to be run with ROS or something? My original intent with the ina260 test files was for them to be completely standalone, with no need to run ROS to test the ina260.
There was a problem hiding this comment.
Ina260 is a pip package so no library included here!
No ROS required for it.
There was a problem hiding this comment.
Oh, wow, didn't realize that! Alright sounds good. Might be good to add a docstring at the top of the file telling users to pip install it in that case.
Uses the ina260 library (
pip3 install ina260) to get current, voltage, power readouts. Add to default launch.Future work could include integrating low battery capacity readouts into some warning system.
closes #168