Fix #441, cf delete files during error when tx #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * See description in cf_cfdp.h for argument/return detail | ||
| * | ||
| *-----------------------------------------------------------------*/ | ||
| bool CF_CFDP_IsPollingDir(const char * src_file, uint8 chan_num) |
Check notice
Code scanning / CodeQL
Long function without assertion Note
| void CF_CFDP_HandleNotKeepFile(CF_Transaction_t *txn) | ||
| { | ||
| /* Sender */ | ||
| if (CF_CFDP_IsSender(txn)) |
Check warning
Code scanning / CodeQL
Side effect in a Boolean expression Warning
| * See description in cf_cfdp.h for argument/return detail | ||
| * | ||
| *-----------------------------------------------------------------*/ | ||
| void CF_CFDP_MoveFile(const char *src, const char *dest_dir) |
Check notice
Code scanning / CodeQL
Long function without assertion Note
| * See description in cf_cfdp.h for argument/return detail | ||
| * | ||
| *-----------------------------------------------------------------*/ | ||
| void CF_CFDP_HandleNotKeepFile(CF_Transaction_t *txn) |
Check notice
Code scanning / CodeQL
Long function without assertion Note
Fix nasa#441, Update to handle error during tx. For polling, the file gets moved or deleted to pervent infinite loop. For others, the file does not get deleted. Update Unit Test and documentation.
avan989
force-pushed
the
Fix-441-cf-delete-file-transmit-error
branch
from
1441e5d
to
b357f17
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #441, Update to handle an error during tx. For polling, the file gets moved or deleted to prevent an infinite loop. For others, the file does not get deleted. Update Unit Test.
Checklist (Please check before submitting)
Describe the contribution
A clear and concise description of what the contribution is.
Fix cf delete file when there is an error during tx #441, cf delete file during error when tx.
Testing performed
Steps taken to test the contribution:
Tx class 2 cmd and make fail. ( ack limit reached, no eof-ack)
Check file has not been deleted.
Put in polling directory and see and make fail (ack limit reached, no eof-ack)
Check file has been moved to fail directory
File is no longer in polling directory
Put in polling directory, no failing directory, and make fail ( ack limit reached, no eof-ack)
The file is deleted from the polling directory.
Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.
a. if the file is not in a polling directory, do nothing
b. if the file is in a polling directory, attempt to move to the "fail" directory and delete it from the polling directory.
System(s) tested on
Tested on a docker container with ubuntu22.04 running against COSMOS
Additional context
Add any other context about the contribution here.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)
Anh Van, GSFC