CMR-9798: Removing umm-lib acl-matchers and Updated umm-spec-lib acl-m…

[eereiter]

…atchers, but didn't move them.

Overview

remove umm-lib.acl-matchers and fix up umm-spec acl-matchers.

What is the Solution?

remove umm-lib.acl-matchers and fix up umm-spec acl-matchers.

What areas of the application does this impact?

umm-lib/acl-matchers
umm-spec-lib/acl-matchers

Checklist

• [ x] I have updated/added unit and integration tests that prove my fix is effective or that my feature works
• [ x] New and existing unit and int tests pass locally and remotely with my changes
• [ x] I have removed unnecessary/dead code and imports in files I have changed
• [ x] I have performed a self-review of my own code
• [ x] I have commented my code, particularly in hard-to-understand areas
• [ x] I have made corresponding changes to the documentation
• [ x] My changes generate no new warnings

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 63.33333% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 57.83%. Comparing base (9590e3f) to head (5e1d1bb).
Report is 2 commits behind head on master.

Files	Patch %	Lines
umm-spec-lib/src/cmr/umm_spec/acl_matchers.clj	53.19%	19 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2097      +/-   ##
==========================================
+ Coverage   57.44%   57.83%   +0.38%     
==========================================
  Files        1042     1041       -1     
  Lines       70323    70289      -34     
  Branches     1883     1982      +99     
==========================================
+ Hits        40395    40649     +254     
+ Misses      28113    27771     -342     
- Partials     1815     1869      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jmaeng72]

Is this the method that caused us trouble in runtime in SIT with the cache? That it couldn't find the method?

[eereiter]

I don't remember, but I rewrote it not to use multi functions, because it doesn't need it. I was also able combine most of the code between the collection and the granule filter matching code.