Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MariaDB ABM parsing bug and add some error checking #65

Merged
merged 3 commits into from
Jan 27, 2022

Conversation

IbraheemYSaleh
Copy link
Contributor

No description provided.

@IbraheemYSaleh
Copy link
Contributor Author

Fixes:
https://github.jpl.nasa.gov/ASEC/AMMOS-CryptoLib/issues/15
and
#57

As well as catches a segfault when invalid frame headers are passed and overflow in the size calculation.

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2022

Codecov Report

Merging #65 (e69534e) into collab_main (5eecd33) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           collab_main      #65      +/-   ##
===============================================
- Coverage        84.20%   84.18%   -0.02%     
===============================================
  Files               16       16              
  Lines             3603     3605       +2     
===============================================
+ Hits              3034     3035       +1     
- Misses             569      570       +1     
Impacted Files Coverage Δ
src/src_main/crypto_tc.c 89.93% <50.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5eecd33...e69534e. Read the comment docs.

@IbraheemYSaleh IbraheemYSaleh merged commit 3cada00 into collab_main Jan 27, 2022
@dccutrig dccutrig deleted the FixMariaDBABMBug branch March 1, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants