Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

62 maximum frame length #87

Merged
merged 3 commits into from
Mar 14, 2022
Merged

62 maximum frame length #87

merged 3 commits into from
Mar 14, 2022

Conversation

dccutrig
Copy link
Contributor

No description provided.

@dccutrig dccutrig added the enhancement New feature or request label Mar 14, 2022
@dccutrig dccutrig linked an issue Mar 14, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2022

Codecov Report

Merging #87 (5d395ad) into dev (b7d23e2) will increase coverage by 0.04%.
The diff coverage is 87.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #87      +/-   ##
==========================================
+ Coverage   83.46%   83.51%   +0.04%     
==========================================
  Files          18       18              
  Lines        4184     4227      +43     
==========================================
+ Hits         3492     3530      +38     
- Misses        692      697       +5     
Impacted Files Coverage Δ
src/src_main/sadb_routine_inmemory.template.c 74.94% <0.00%> (-0.86%) ⬇️
util/src_util/ut_kmc_crypto_with_mtls_sadb.c 0.00% <0.00%> (ø)
src/src_main/crypto_config.c 95.56% <100.00%> (+0.03%) ⬆️
src/src_main/crypto_tc.c 91.62% <100.00%> (+0.21%) ⬆️
util/src_util/et_dt_validation.c 98.26% <100.00%> (ø)
util/src_util/ut_crypto.c 100.00% <100.00%> (ø)
util/src_util/ut_tc_apply.c 100.00% <100.00%> (ø)
util/src_util/ut_tc_process.c 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7d23e2...5d395ad. Read the comment docs.

Copy link
Contributor

@IbraheemYSaleh IbraheemYSaleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me 👍 ... Only comment I have is that I think it's worth it to quickly add 2 unit tests that hit these two new error conditions.

@dccutrig dccutrig closed this Mar 14, 2022
@dccutrig dccutrig reopened this Mar 14, 2022
@dccutrig dccutrig merged commit 0097af2 into dev Mar 14, 2022
@jlucas9 jlucas9 deleted the 62-maximum-frame-length branch March 23, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maximum Frame length wrt SDLS added fields
3 participants